DOC fix EX02 algorithms.factorize docstring #51243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! can you remove them from the excludes list? |
|
Done. Thanks for the review @MarcoGorelli |
MarcoGorelli
suggested changes
Feb 9, 2023
There was a problem hiding this comment.
Looks like these are failing
Error: /home/runner/work/pandas/pandas/pandas/core/base.py:1138:EX02:pandas.Index.factorize:Examples do not pass tests:
**********************************************************************
Line 53, in pandas.Index.factorize
Failed example:
codes
Expected:
array([0, 0, 1, 2, 0], dtype=int64)
Got:
array([0, 0, 1, 2, 0])
**********************************************************************
Line 62, in pandas.Index.factorize
Failed example:
codes
Expected:
array([1, 1, 0, 2, 1], dtype=int64)
Got:
array([1, 1, 0, 2, 1])
**********************************************************************
Line 72, in pandas.Index.factorize
Failed example:
codes
Expected:
array([ 0, -1, 1, 2, 0], dtype=int64)
Got:
array([ 0, -1, 1, 2, 0])
**********************************************************************
Line 83, in pandas.Index.factorize
Failed example:
codes
Expected:
array([0, 0, 1], dtype=int64)
Got:
array([0, 0, 1])
**********************************************************************
Line 97, in pandas.Index.factorize
Failed example:
codes
Expected:
array([0, 0, 1], dtype=int64)
Got:
array([0, 0, 1])
**********************************************************************
Line 107, in pandas.Index.factorize
Failed example:
codes
Expected:
array([ 0, 1, 0, -1], dtype=int64)
Got:
array([ 0, 1, 0, -1])
**********************************************************************
Line 113, in pandas.Index.factorize
Failed example:
codes
Expected:
array([0, 1, 0, 2], dtype=int64)
Got:
array([0, 1, 0, 2])
Error: /home/runner/work/pandas/pandas/pandas/core/base.py:1138:EX02:pandas.Series.factorize:Examples do not pass tests:
**********************************************************************
Line 53, in pandas.Series.factorize
Failed example:
codes
Expected:
array([0, 0, 1, 2, 0], dtype=int64)
Got:
array([0, 0, 1, 2, 0])
**********************************************************************
Line 62, in pandas.Series.factorize
Failed example:
codes
Expected:
array([1, 1, 0, 2, 1], dtype=int64)
Got:
array([1, 1, 0, 2, 1])
**********************************************************************
Line 72, in pandas.Series.factorize
Failed example:
codes
Expected:
array([ 0, -1, 1, 2, 0], dtype=int64)
Got:
array([ 0, -1, 1, 2, 0])
**********************************************************************
Line 83, in pandas.Series.factorize
Failed example:
codes
Expected:
array([0, 0, 1], dtype=int64)
Got:
array([0, 0, 1])
**********************************************************************
Line 97, in pandas.Series.factorize
Failed example:
codes
Expected:
array([0, 0, 1], dtype=int64)
Got:
array([0, 0, 1])
**********************************************************************
Line 107, in pandas.Series.factorize
Failed example:
codes
Expected:
array([ 0, 1, 0, -1], dtype=int64)
Got:
array([ 0, 1, 0, -1])
**********************************************************************
Line 113, in pandas.Series.factorize
Failed example:
codes
Expected:
array([0, 1, 0, 2], dtype=int64)
Got:
array([0, 1, 0, 2])
Error: /home/runner/work/pandas/pandas/pandas/core/algorithms.py:612:EX02:pandas.factorize:Examples do not pass tests:
**********************************************************************
Line 58, in pandas.factorize
Failed example:
codes
Expected:
array([0, 0, 1, 2, 0], dtype=int64)
Got:
array([0, 0, 1, 2, 0])
**********************************************************************
Line 67, in pandas.factorize
Failed example:
codes
Expected:
array([1, 1, 0, 2, 1], dtype=int64)
Got:
array([1, 1, 0, 2, 1])
**********************************************************************
Line 77, in pandas.factorize
Failed example:
codes
Expected:
array([ 0, -1, 1, 2, 0], dtype=int64)
Got:
array([ 0, -1, 1, 2, 0])
**********************************************************************
Line 88, in pandas.factorize
Failed example:
codes
Expected:
array([0, 0, 1], dtype=int64)
Got:
array([0, 0, 1])
**********************************************************************
Line 102, in pandas.factorize
Failed example:
codes
Expected:
array([0, 0, 1], dtype=int64)
Got:
array([0, 0, 1])
**********************************************************************
Line 112, in pandas.factorize
Failed example:
codes
Expected:
array([ 0, 1, 0, -1], dtype=int64)
Got:
array([ 0, 1, 0, -1])
**********************************************************************
Line 118, in pandas.factorize
Failed example:
codes
Expected:
array([0, 1, 0, 2], dtype=int64)
Got:
array([0, 1, 0, 2])
Partially validate docstrings (EX02) DONE
added 2 commits
February 9, 2023 15:23
…fix_ex02_docstrings_factorize
|
The Docstring validation should be good now. |
MarcoGorelli
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Towards #51236.
Fix EX02 docstring errors for :
pandas.factorizepandas.Index.factorizepandas.Series.factorize