-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC fix EX02 errors in docstrings #51236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi, currently working on :
|
For future Windows contributors. If you get a weird flake8 PermissionError when running scripts/validate_docstrings.py you can fix it by manually adding delete=False in the tempfile context manager (validate_docstrings.py, line 210). Note that you will need to manually delete the temporary file after this change. Also, do not push this change ! Related issue: stackoverflow |
thanks @albuzenet - if that's the case, it suggests that the current validate_docstrings.py code should probably be improved. Do you want to make a PR to rewrite it using namedtemporaryfile? |
Sure @MarcoGorelli. Should I open a new issue ? |
sure (or feel free to just submit a PR directly, thanks for having spotted this) |
Working on: |
Hello, I am currently working on: |
Hi, I will work on: |
I am working on: |
I am working on: |
Hi, I am currently working on: pandas.api.types.is_interval_dtype |
I am working on: |
Hi, I will take up the following set:
|
I am working on: |
I am working on: |
Hi, I am working on: |
Hi,
Others can pick it up. Apologies for blocking the set. |
Hi. I'll take functions |
Hello, pandas.api.types.is_interval_dtype Others can pick it up. Apologies for blocking the set. I will close my incomplete pull request for this issue. |
The pull request above corrects the docstrings for: Sorry for not mentioning that I would take them in advance, they were dropped by somebody else a few hours ago and I did them to gain some confidence since I'm working on a few for |
I am working on: |
Hi, I am working on: |
Hi, I am already working on:
PR is as above. |
Thanks - what you've done is fine, if someone leaves a comment and then doesn't submit anything for 1-2 weeks it's perfectly fine to take over |
Hi I'm going to work on: |
Hello everyone, I am going to work on the following: |
those are already done there's only 6 left, we're close to closing this one off |
Sorry, due to some reason, I won't be able to fix |
I'll take the methods mentioned directly above: |
cool, thanks or feel free to take all the remaining ones, remove the partial EX02 check, and add EX02 to Lines 82 to 83 in ced9833
|
Great, I'm working on them now! |
We did, thanks everyone! |
pandas has a script for validating docstrings
pandas/ci/code_checks.sh
Lines 560 to 568 in ced9833
which can be run with
Currently, many functions fail the EX02 check, and so are excluded from the check.
The task here is:
./ci/code_checks.sh docstrings
Please don't comment
take
as multiple people can work on this simultaneously. You also don't need to ask for permission to work on this, feel free to just start 😄 Though if you're working on some set of functions you can comment thatIf you're new here, please check the contributing guide https://pandas.pydata.org/docs/dev/development/contributing.html
TIP:
./ci/code_checks.sh docstrings
may take a while to run - you may want to comment-out thedocstrings
check which checksEX01
and the part which checks all the other codes (these are currently lines 86 - 577)The text was updated successfully, but these errors were encountered: