Skip to content

TEST: join df with categorical multiIndex #51088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 6, 2023
Merged

TEST: join df with categorical multiIndex #51088

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
40bd638
TEST: join df with categorical multiIndex
natmokval Jan 31, 2023
ea7fe92
compare result and expected DataFrame
natmokval Feb 1, 2023
a2988bc
add pytest.mark.parameterize to the test
natmokval Feb 1, 2023
e0b78d8
use dataframes from the original example
natmokval Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions pandas/tests/reshape/merge/test_join.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import numpy as np
import pytest

from pandas.core.dtypes.common import is_categorical_dtype

import pandas as pd
from pandas import (
Categorical,
Expand Down Expand Up @@ -956,3 +958,27 @@ def test_join_empty(left_empty, how, exp):
expected = expected.rename_axis("A")

tm.assert_frame_equal(result, expected)


def test_join_multiindex_categorical_output_index_dtype():
# GH#50906
df1 = DataFrame(
{
"idx1": Categorical(["a", "a", "a"]),
"idx2": Categorical(["a", "a", "b"]),
"data": [1, 2, 3],
}
).set_index(["idx1", "idx2"])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for working on this

why not use the example from #50906? for regression tests, if the original example is small and self-contained, it'd probably be safer to just use that directly
the rest looks good though 👍


df2 = DataFrame(
{
"idx1": Categorical(["a", "a", "a"]),
"idx2": Categorical(["a", "b", "b"]),
"data2": [1, 2, 3],
}
).set_index(["idx1", "idx2"])

for how in ["inner", "outer", "left", "right"]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use pytest.mark.parameterize for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, of course. Added parametrize to this commit

df = df1.join(df2, how=how)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you name this result and compare to an expected DataFrame. This will compare the types as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mroeschke. I corrected the test as you suggested.

assert is_categorical_dtype(df.index.levels[0]) is True
assert is_categorical_dtype(df.index.levels[1]) is True