TEST: join df with categorical multiIndex #51088
Conversation
| ).set_index(["idx1", "idx2"]) | ||
|
|
||
| for how in ["inner", "outer", "left", "right"]: | ||
| df = df1.join(df2, how=how) |
There was a problem hiding this comment.
Could you name this result and compare to an expected DataFrame. This will compare the types as well
There was a problem hiding this comment.
Thank you @mroeschke. I corrected the test as you suggested.
mroeschke
added
the
Testing
| } | ||
| ).set_index(["idx1", "idx2"]) | ||
|
|
||
| for how in ["inner", "outer", "left", "right"]: |
There was a problem hiding this comment.
Could you use pytest.mark.parameterize for this?
There was a problem hiding this comment.
Yes, of course. Added parametrize to this commit
| df1 = DataFrame( | ||
| { | ||
| "idx1": Categorical(["a", "a", "a"]), | ||
| "idx2": Categorical(["a", "a", "b"]), | ||
| "data": [1, 2, 3], | ||
| } | ||
| ).set_index(["idx1", "idx2"]) |
There was a problem hiding this comment.
thanks for working on this
why not use the example from #50906? for regression tests, if the original example is small and self-contained, it'd probably be safer to just use that directly
the rest looks good though 👍
|
Thank you, I am looking forward to seeing a cat :) |
|
this is currently marked as draft:
it looks ready though, anything else need doing? if you mark as ready for review I think we can ship it |
|
I forgot to change the status of the PR. Now it is "ready for review" :) |
Add test to check index dtype after joining DataFrames with categorical multiIndex.