-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
REF: Avoid kwargs in rename_axis #51072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MarcoGorelli
merged 12 commits into
pandas-dev:main
from
mroeschke:ref/rename_axis/no_kwargs
Feb 2, 2023
Merged
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2c5bf56
Explicitly list rename_axis arguments
mroeschke 2ba4ee2
Explicitly list rename_axis arguments
mroeschke 68334ba
Merge remote-tracking branch 'upstream/main' into ref/rename_axis/no_…
mroeschke 1bd37b8
Fix default value
mroeschke d13a44f
Fix tests
mroeschke 6710600
Merge remote-tracking branch 'upstream/main' into ref/rename_axis/no_…
mroeschke 29641a7
Fix copy default and docstring
mroeschke 9580d2a
Merge remote-tracking branch 'upstream/main' into ref/rename_axis/no_…
mroeschke e6e2591
Remove unneeded
mroeschke 5bad6ca
Merge remote-tracking branch 'upstream/main' into ref/rename_axis/no_…
mroeschke 42b7e1d
make keyword only
mroeschke 18c1e62
Merge remote-tracking branch 'upstream/main' into ref/rename_axis/no_…
mroeschke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can these be keyword-only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could deprecate and make them keyword only in a follow up, but as is they cannot be yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused - why can't they be made keyword-only?
These arguments (e.g.
index
) already can't be passed positionally, so which behaviour which currently works would break?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah shoot I misread the previous signature. Yeah these should be able to be keyword only