REF: Avoid kwargs in rename_axis #51072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/generic.py
Outdated
| index=..., | ||
| columns=..., | ||
| axis: Axis = ..., | ||
| copy: bool_t = ..., |
There was a problem hiding this comment.
can these be keyword-only?
There was a problem hiding this comment.
We could deprecate and make them keyword only in a follow up, but as is they cannot be yet.
There was a problem hiding this comment.
I'm confused - why can't they be made keyword-only?
These arguments (e.g. index) already can't be passed positionally, so which behaviour which currently works would break?
There was a problem hiding this comment.
Ah shoot I misread the previous signature. Yeah these should be able to be keyword only
MarcoGorelli
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unaccepted kwargs already raised a
TypeError, so can just replace with the accepted arguments which allows some cleanup