Revert "CI temporarily pin numpy" #50706
Conversation
This reverts commit f31da23.
pandas/compat/numpy/__init__.py
Outdated
| @@ -9,6 +9,7 @@ | |||
| np_version_under1p21 = _nlv < Version("1.21") | |||
| np_version_under1p22 = _nlv < Version("1.22") | |||
| np_version_gte1p22 = _nlv >= Version("1.22") | |||
| np_version_gte1p24 = _nlv >= Version("1.24") | |||
There was a problem hiding this comment.
Was this added since this PR is to be backported and it's in the 1.5.x branch?
There was a problem hiding this comment.
I added it in the second commit (the one after the pure revert, which also catches the SystemError)
TBH I accidentally left it in after I was trying things out, and then figured I'd just leave it here as it'll probably be useful at some point. Reckon it needs removing?
There was a problem hiding this comment.
Yeah I would opt to only add this until we really need it (and IIRC you may have wanted to remove these in favor of direct version checks in the code?)
There was a problem hiding this comment.
that was only for the Python version, because pyupgrade will rewrite them (they don't rewrite based on 3rd party libraries)
OK, sure, I'll remove this line - is the rest alright?
|
thanks - merging then as this was green, and the last commit just reverted adding an unused variable |
* Revert "CI: Temporarily pin numpy (pandas-dev#50356)" This reverts commit f31da23. * maybe fixup test collection * remove np_version_gte1p24 Co-authored-by: MarcoGorelli <>
* Revert "CI: Temporarily pin numpy (pandas-dev#50356)" This reverts commit f31da23. * maybe fixup test collection * remove np_version_gte1p24 Co-authored-by: MarcoGorelli <>
#50715) Backport PR #50706: Revert "CI temporarily pin numpy" Co-authored-by: Marco Edward Gorelli <[email protected]>
Reverts #50356