Skip to content

CI temporarily pin numpy #50356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 20, 2022
Merged

CI temporarily pin numpy #50356

merged 4 commits into from
Dec 20, 2022

Conversation

MarcoGorelli
Copy link
Member

Looks like numba is failing with the latest numpy release numba/numba#8615

Let's temporarily pin numpy to get CI green, and then lift the pin once it's solved in numba?

@MarcoGorelli MarcoGorelli requested a review from phofl December 20, 2022 10:55
@MarcoGorelli MarcoGorelli added the CI Continuous Integration label Dec 20, 2022
MarcoGorelli added 2 commits December 20, 2022 10:58
@phofl
Copy link
Member

phofl commented Dec 20, 2022

I guess you have to pin in the asv config as well?

@MarcoGorelli
Copy link
Member Author

not strictly necessary for CI, as --python=same is used in that job - but yeah, probably better, thanks

MarcoGorelli
MarcoGorelli commented Dec 20, 2022
View reviewed changes
asv_bench/asv.conf.json
@@ -41,7 +41,7 @@
// pip (with all the conda available packages installed first,
// followed by the pip installed packages).
"matrix": {
"numpy": [],
"numpy": ["1.23.5"], // https://github.com/pandas-dev/pandas/pull/50356
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asv doesn't allow pinning with <

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'd just go with the newest version as well.

@phofl phofl added this to the 1.5.3 milestone Dec 20, 2022
@phofl phofl merged commit f31da23 into pandas-dev:main Dec 20, 2022
@phofl
Copy link
Member

phofl commented Dec 20, 2022

thx @MarcoGorelli

@meeseeksmachine meeseeksmachine mentioned this pull request Dec 20, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Dec 20, 2022
@MarcoGorelli @meeseeksmachine
Backport PR pandas-dev#50356: CI temporarily pin numpy
a5c1956
@jorisvandenbossche
Copy link
Member

Could we remove numba in some of the envs instead? Because not testing with the latest numpy anywhere doesn't seem like a good situation?
(I don't know the timeline of a fix fox this in numba, but the issue is already open a while)

@MarcoGorelli
Copy link
Member Author

the 311-dev job tests with the latest (nightly) numpy, and that one doesn't have numba

perhaps let's wait a few days to see if there's any progress, and if not just remove numba from CI 'til they resolve it?

phofl pushed a commit that referenced this pull request Dec 21, 2022
@meeseeksmachine @MarcoGorelli
Backport PR #50356 on branch 1.5.x (CI temporarily pin numpy) (#50358)
3f41747 
Backport PR #50356: CI temporarily pin numpy

Co-authored-by: Marco Edward Gorelli <[email protected]>
MarcoGorelli added a commit that referenced this pull request Jan 12, 2023
@MarcoGorelli
Revert "CI: Temporarily pin numpy (#50356)"
ebbb9ad 
This reverts commit f31da23.
@MarcoGorelli MarcoGorelli mentioned this pull request Jan 12, 2023
Merged
MarcoGorelli added a commit that referenced this pull request Jan 12, 2023
@MarcoGorelli
Revert "CI temporarily pin numpy" (#50706)
754394c 
* Revert "CI: Temporarily pin numpy (#50356)"

This reverts commit f31da23.

* maybe fixup test collection

* remove np_version_gte1p24

Co-authored-by: MarcoGorelli <>
phofl pushed a commit to phofl/pandas that referenced this pull request Jan 12, 2023
@MarcoGorelli @phofl
Revert "CI temporarily pin numpy" (pandas-dev#50706)
20d8e2b 
* Revert "CI: Temporarily pin numpy (pandas-dev#50356)"

This reverts commit f31da23.

* maybe fixup test collection

* remove np_version_gte1p24

Co-authored-by: MarcoGorelli <>
phofl pushed a commit to phofl/pandas that referenced this pull request Jan 13, 2023
@MarcoGorelli @phofl
Revert "CI temporarily pin numpy" (pandas-dev#50706)
92ef519 
* Revert "CI: Temporarily pin numpy (pandas-dev#50356)"

This reverts commit f31da23.

* maybe fixup test collection

* remove np_version_gte1p24

Co-authored-by: MarcoGorelli <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration
Projects
None yet
Milestone
1.5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcoGorelli @phofl @jorisvandenbossche