Skip to content

CI: Add regular 3.11 pipeline #50696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jan 16, 2023
Merged

CI: Add regular 3.11 pipeline #50696

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
54cff9d
CI: Try regular 3.11 pipeline
phofl Jan 12, 2023
b4cf4fb
Avoid pyarrow test on all versions
phofl Jan 12, 2023
88462e2
Disable dev workflow
phofl Jan 12, 2023
7bdb1d9
Fix typo
phofl Jan 12, 2023
febe6e4
Fix test
phofl Jan 14, 2023
4364252
Update deps
phofl Jan 14, 2023
ce78c1d
Merge remote-tracking branch 'upstream/main' into ci
phofl Jan 14, 2023
e84c458
Remov pytables tests
phofl Jan 15, 2023
5a80bf4
Revert "Remov pytables tests"
phofl Jan 15, 2023
1305cf7
Pin pytables to version that is supported for 3.11
phofl Jan 15, 2023
ab4ea19
Add comment
phofl Jan 15, 2023
c19d143
Remove pytables
phofl Jan 15, 2023
62e5bf5
Merge branch 'main' into ci
phofl Jan 15, 2023
77eac07
Update actions-311.yaml
phofl Jan 15, 2023
7c9dc77
Add numba
phofl Jan 15, 2023
ff06b2b
Update actions-311.yaml
phofl Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/macos-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
strategy:
matrix:
os: [macos-latest, windows-latest]
env_file: [actions-38.yaml, actions-39.yaml, actions-310.yaml]
env_file: [actions-38.yaml, actions-39.yaml, actions-310.yaml, actions-311.yaml]
fail-fast: false
runs-on: ${{ matrix.os }}
name: ${{ format('{0} {1}', matrix.os, matrix.env_file) }}
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/python-dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,14 @@ name: Python Dev
on:
push:
branches:
- main
- 1.5.x
# - main
# - 1.5.x
- None
pull_request:
branches:
- main
- 1.5.x
# - main
# - 1.5.x
- None
Comment on lines -26 to +33
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phofl I'm confused, why comment these out?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My reasoning was that it would be easier to add them back in for 3.12, but no strong opinion, can remove if you prefer

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think previously we would comment/uncomment if: false below to temporarily disable this workflow

Copy link
Member

@MarcoGorelli MarcoGorelli Feb 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok - that's fine, thnx for explaining

paths-ignore:
- "doc/**"

Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/ubuntu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
timeout-minutes: 180
strategy:
matrix:
env_file: [actions-38.yaml, actions-39.yaml, actions-310.yaml]
env_file: [actions-38.yaml, actions-39.yaml, actions-310.yaml, actions-311.yaml]
pattern: ["not single_cpu", "single_cpu"]
pyarrow_version: ["7", "8", "9", "10"]
include:
Expand Down Expand Up @@ -92,6 +92,12 @@ jobs:
pyarrow_version: "8"
- env_file: actions-39.yaml
pyarrow_version: "9"
- env_file: actions-311.yaml
pyarrow_version: "7"
- env_file: actions-311.yaml
pyarrow_version: "8"
- env_file: actions-311.yaml
pyarrow_version: "9"
fail-fast: false
name: ${{ matrix.name || format('{0} pyarrow={1} {2}', matrix.env_file, matrix.pyarrow_version, matrix.pattern) }}
env:
Expand Down
56 changes: 56 additions & 0 deletions ci/deps/actions-311.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
name: pandas-dev
channels:
- conda-forge
dependencies:
- python=3.11

# build dependencies
- versioneer[toml]
- cython>=0.29.32

# test dependencies
- pytest>=7.0
- pytest-cov
- pytest-xdist>=2.2.0
- psutil
- pytest-asyncio>=0.17
- boto3

# required dependencies
- python-dateutil
- numpy<1.24
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be unpinned?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's check, copied 3.10 when I started but seems to work there now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to keep it pinned. Numba pins it indirectly on the other jobs, but since we don't install it here, we have to keep the pin

- pytz

# optional dependencies
- beautifulsoup4
- blosc
- bottleneck
- brotlipy
- fastparquet
- fsspec
- html5lib
- hypothesis
- gcsfs
- jinja2
- lxml
- matplotlib>=3.6.1
- numexpr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is numba commented out somewhere in this file?

Copy link
Member Author

@phofl phofl Jan 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No just removed it completely, can add it as a comment if you prefer. I just left pytables in because they already released it but the conda packages are not yet build

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add it back as a comment so we don't forget it? Thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

- openpyxl
- odfpy
- pandas-gbq
- psycopg2
- pymysql
# - pytables>=3.8.0 # first version that supports 3.11
- pyarrow
- pyreadstat
- python-snappy
- pyxlsb
- s3fs>=2021.08.0
- scipy
- sqlalchemy<1.4.46
- tabulate
- tzdata>=2022a
- xarray
- xlrd
- xlsxwriter
- zstandard
5 changes: 3 additions & 2 deletions pandas/tests/extension/test_arrow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import pytest

from pandas.compat import (
PY311,
is_ci_environment,
is_platform_windows,
pa_version_under6p0,
Expand All @@ -49,7 +50,7 @@
)
from pandas.tests.extension import base

pa = pytest.importorskip("pyarrow", minversion="1.0.1")
pa = pytest.importorskip("pyarrow", minversion="6.0.0")

from pandas.core.arrays.arrow.array import ArrowExtensionArray

Expand Down Expand Up @@ -287,7 +288,7 @@ def test_from_sequence_pa_array_notimplemented(self, request):

def test_from_sequence_of_strings_pa_array(self, data, request):
pa_dtype = data.dtype.pyarrow_dtype
if pa.types.is_time64(pa_dtype) and pa_dtype.equals("time64[ns]"):
if pa.types.is_time64(pa_dtype) and pa_dtype.equals("time64[ns]") and not PY311:
request.node.add_marker(
pytest.mark.xfail(
reason="Nanosecond time parsing not supported.",
Expand Down