CI: Add regular 3.11 pipeline #50696
Conversation
|
Looks like using mamba for the env fixes the installation issue, but we have some weird segfault on the 3.11 single cpu build |
|
if that works, would this one still be necessary? |
|
This one takes precedence over the dev build. It's kinda unrelated but after seeing the failures today I remembered that I wanted to look into it anyway. The dev build only tests with our required dependencies while this one enables a full test-run on 3.11 (except numba since it's not compatible with 3.11 yet). This would give us the same test coverage as the other supported python versions. Have to get the ci passing before that though. |
ci/deps/actions-311.yaml
Outdated
| - cython>=0.29.32 | ||
|
|
||
| # test dependencies | ||
| - pytest>=6.0 |
There was a problem hiding this comment.
Noting some of these got updated in #50481
|
pytables is not yet available for 3.11 on conda-forge. |
|
Last build was green on 3.11, merging main to get up to date. @lithomas1 would you mind having a look? |
ci/deps/actions-311.yaml
Outdated
|
|
||
| # required dependencies | ||
| - python-dateutil | ||
| - numpy<1.24 |
There was a problem hiding this comment.
Let's check, copied 3.10 when I started but seems to work there now
There was a problem hiding this comment.
Have to keep it pinned. Numba pins it indirectly on the other jobs, but since we don't install it here, we have to keep the pin
| - jinja2 | ||
| - lxml | ||
| - matplotlib>=3.6.1 | ||
| - numexpr |
There was a problem hiding this comment.
Is numba commented out somewhere in this file?
There was a problem hiding this comment.
No just removed it completely, can add it as a comment if you prefer. I just left pytables in because they already released it but the conda packages are not yet build
There was a problem hiding this comment.
Can you add it back as a comment so we don't forget it? Thanks.
|
Merging to get our stuff tested properly on 3.11 |
| - main | ||
| - 1.5.x | ||
| # - main | ||
| # - 1.5.x | ||
| - None | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| - 1.5.x | ||
| # - main | ||
| # - 1.5.x | ||
| - None |
There was a problem hiding this comment.
@phofl I'm confused, why comment these out?
There was a problem hiding this comment.
My reasoning was that it would be easier to add them back in for 3.12, but no strong opinion, can remove if you prefer
There was a problem hiding this comment.
I think previously we would comment/uncomment if: false below to temporarily disable this workflow
There was a problem hiding this comment.
ah ok - that's fine, thnx for explaining
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.