Skip to content

ENH: Add cumsum to ArrowExtensionArray #50389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 24, 2022
Merged

ENH: Add cumsum to ArrowExtensionArray #50389

merged 5 commits into from
Dec 24, 2022

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Dec 22, 2022 •
edited
Loading

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Don't think a whatsnew is needed since EA._accumulate was added in 2.0

@mroeschke mroeschke added Enhancement Arrow pyarrow functionality labels Dec 22, 2022
phofl
phofl reviewed Dec 22, 2022
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like cumsum was added in 9.0 to pyarrow

phofl
phofl approved these changes Dec 23, 2022
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typing issue, otherwise lgmt

@phofl phofl added this to the 2.0 milestone Dec 24, 2022
@phofl phofl merged commit 9918c84 into pandas-dev:main Dec 24, 2022
@phofl
Copy link
Member

phofl commented Dec 24, 2022

thx @mroeschke

@mroeschke mroeschke deleted the enh/arrow/cumsum branch December 24, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Arrow pyarrow functionality Enhancement
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @phofl