CI Pin numpy 32 bit #50384
Merged
CI Pin numpy 32 bit #50384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
pin-numpy-32-bit
branch
from
3804a04 to
344a7d7
Compare
5 tasks
topper-123
approved these changes
Dec 22, 2022
|
yup, here #50392 |
|
from #49777 it seems there a preference for not pinning numpy unless it's necessary, so I'll just xfail the test |
MarcoGorelli
force-pushed
the
pin-numpy-32-bit
branch
from
806fd20 to
104ebcf
Compare
mroeschke
approved these changes
Dec 22, 2022
|
Thanks @MarcoGorelli |
bnavigator
reviewed
Dec 23, 2022
| @@ -733,7 +736,7 @@ def test_constructor_cast(self): | |||
| with pytest.raises(ValueError, match=msg): | |||
| Series(["a", "b", "c"], dtype=float) | |||
|
|
|||
| @pytest.mark.xfail(np_version_gte1p24, reason="GH49777") | |||
| @pytest.mark.xfail(np_version_gte1p24 and not IS64, reason="GH49777") | |||
There was a problem hiding this comment.
@MarcoGorelli The test also fails on 64bit
There was a problem hiding this comment.
At least for me on openSUSE. I don't know why it does XPASS on your first commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.