Skip to content

CLN remove unnecessary numba-compat code #50392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarcoGorelli opened this issue Dec 22, 2022 · 5 comments
Closed

CLN remove unnecessary numba-compat code #50392

MarcoGorelli opened this issue Dec 22, 2022 · 5 comments
Labels
CI Continuous Integration good first issue

Comments

@MarcoGorelli
Copy link
Member

numpy 1.24.0 can't be used with numba. once numba/numba#8620 is merged, and this is fixed in numba, we can unpin numpy in CI

@MarcoGorelli MarcoGorelli added the CI Continuous Integration label Dec 22, 2022
@MarcoGorelli MarcoGorelli mentioned this issue Dec 22, 2022
5 tasks
@lithomas1 lithomas1 added the Closing Candidate May be closeable, needs more eyeballs label Jan 15, 2023
@lithomas1
Copy link
Member

Probably can close this once numba releases their 1.24.0 support, and this block is deleted.

# TODO: numba is incompatible with numpy 1.24+.
# Once that's fixed, this block should be removed.
if mod_name == "numba":
return False
else:
raise

@jbrockmendel
Copy link
Member

according to numba's release notes 0.57.0 supports numpy 1.24. is this closable?

@MarcoGorelli
Copy link
Member Author

yeah, once we verify that removing

except SystemError:
# TODO: numba is incompatible with numpy 1.24+.
# Once that's fixed, this block should be removed.
if mod_name == "numba":
return False
else:
raise

keeps CI green

anyone fancy making a PR?

@MarcoGorelli MarcoGorelli added good first issue and removed Closing Candidate May be closeable, needs more eyeballs labels Jun 30, 2023
@MarcoGorelli MarcoGorelli changed the title CI unpin numpy CLN remove unnecessary numba-compat code Jun 30, 2023
@ggold7046
Copy link
Contributor

ggold7046 commented Jul 10, 2023

Hi, is this issue still open ?

@mroeschke
Copy link
Member

Looks like #53947 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration good first issue
Projects
None yet
Development

No branches or pull requests

5 participants