BUG/CLN: numpy compat with pandas numeric functions and cln of same (GH4435) #5034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
first PR with big deleted loc! |
|
@jtratner don't worry....going to wait for your big ops merger first! (though I don't think much will conflic) |
|
@jreback I know, nice to finally see something decrease the size of the codebase. Arithmetic refactor ended up about even if you exclude tests and docs changes. |
…g like: np.prod(obj)
as numpy is now passing extra args to the pandas methods!
from the object level modules (e.g. mean/sum/min/max....)
| @@ -1207,89 +1208,11 @@ def f(self, other, axis=0): | |||
| return self._combine(other, na_op, axis=axis) | |||
| f.__name__ = name | |||
| return f | |||
|
|
|||
There was a problem hiding this comment.
@jtratner should this _panel_arith_method be from core/ops.py? (I tried to use ops._arith_method_PANEL) which seemed very similar (though w/o the doc string creation) and it broke a small number of tests, so using this one
There was a problem hiding this comment.
I wasn't clear on this so I didn't touch it, we could probably move it eventually.
jreback
added a commit
that referenced
this pull request
Sep 29, 2013
BUG/CLN: numpy compat with pandas numeric functions and cln of same (GH4435)
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #4787 (keywords now pass thru to _reduce), default for
numericis stillNonecloses #4435
BUG: provide numpy compatibility with 1.7 when implicity using
__array__, IOW:np.prod(s), ornp.mean(df,axis=1)will now work (because numpy decided to try to see if theobject has this function and then pass all kinds of keywords to it, so pandas gets the right function called
with
dtype, andoutpassed in (currently ignored)CLN: refactored all numeric and stat like function (sum/mean/mad/min/max) and cums (cummin/sum..)
to
core/generic.pyfrom Series/DataFrame/Panel