Skip to content

ENH/API: add numeric_only with a default of False to numerics #4787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jreback opened this issue Sep 9, 2013 · 3 comments
Closed

ENH/API: add numeric_only with a default of False to numerics #4787

jreback opened this issue Sep 9, 2013 · 3 comments
Assignees
Labels
API Design Enhancement Numeric Operations Arithmetic, Comparison, and Logical operations

Comments

@jreback
Copy link
Contributor

jreback commented Sep 9, 2013

for:

min,max,sum,var,std,kurt,median,mad,prod,skew

The big reason to do this is a performance hit when you happen to have an object column. and you don't realize it.

See: http://stackoverflow.com/questions/18701569/pandas-dataframe-mean-very-slow-how-can-i-calculate-means-of-columns-faster

_reduce in Frame already supports this (and Series will ignore it), so should be trvial to implement

alternatively could just pass **kwds thru (I think we had an issue about this earlier)

@jreback
Copy link
Contributor Author

jreback commented Sep 9, 2013

related? : #4365

@jbrockmendel
Copy link
Member

-1. Working in/around DataFrame._reduce and groupby operations that have numeric_only, it is a PITA and hides bugs.

@jreback
Copy link
Contributor Author

jreback commented Jan 1, 2020

yep we can just deprecate this i think; do we have an issue for that?

@jreback jreback closed this as completed Jan 1, 2020
@jreback jreback modified the milestones: Contributions Welcome, No action Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Design Enhancement Numeric Operations Arithmetic, Comparison, and Logical operations
Projects
None yet
Development

No branches or pull requests

2 participants