-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Alternate Ubuntu CI fix #50117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternate Ubuntu CI fix #50117
Conversation
This reverts commit 03a981a.
.github/workflows/32-bit-linux.yml
Outdated
@@ -17,7 +17,7 @@ permissions: | |||
|
|||
jobs: | |||
pytest: | |||
runs-on: ubuntu-20.04 | |||
runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't unpin this. You should change this to ubuntu-22.04 everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
20.04 or 22.04? This was just a git revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can bump up to 22.04 if CI is green.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xref #50115
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working, nice!
This is also failing on 1.5.x, can we backport or should we pin the ubuntu version? |
probably fine to backport? |
@meeseeksdev please backport to 1.5.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Backport PR #50117: Alternate Ubuntu CI fix Co-authored-by: William Ayd <[email protected]>
@MarcoGorelli @lithomas1 @jbrockmendel
I think if we clean up some of this dead code we can support a clean build on newer gcc. Lots of layers of indirection to sift through so not entirely clear on what's happening, but I think gcc isn't going to be happy with some of the paths this theoretically produces
#22234