Skip to content

CI try using ubuntu20.04 #50113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Dec 7, 2022

trying to fix broken CI builds

closes #50112

Copy link
Member

@lithomas1 lithomas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@lithomas1
Copy link
Member

lithomas1 commented Dec 7, 2022

BTW, I might be considering making a pre-commit hook to ban uses of latest versions of images from being used.

There's not really much benefit to doing this, and we already pin when building wheels (I've been burned by this in the past, when Visual Studio 2017 was upgraded to Visual Studio 2019).

@MarcoGorelli
Copy link
Member Author

Thanks - jobs are passing now, so let's merge to unblock all other PRs

BTW, I might be considering making a pre-commit hook to ban uses of latest versions of images from being used.

Nice! I'm all for automation

@MarcoGorelli MarcoGorelli modified the milestones: 2.0, 1.5.3 Dec 7, 2022
@MarcoGorelli MarcoGorelli added the CI Continuous Integration label Dec 7, 2022
@MarcoGorelli MarcoGorelli merged commit 03a981a into pandas-dev:main Dec 7, 2022
@lumberbot-app
Copy link

lumberbot-app bot commented Dec 7, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 1.5.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 03a981ae61e685bb6c35234a6fb78a68373af0c6
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #50113: CI try using ubuntu20.04'
  1. Push to a named branch:
git push YOURFORK 1.5.x:auto-backport-of-pr-50113-on-1.5.x
  1. Create a PR against branch 1.5.x, I would have named this PR:

"Backport PR #50113 on branch 1.5.x (CI try using ubuntu20.04)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@phofl
Copy link
Member

phofl commented Dec 7, 2022

Can you open an issue? We should think about upgrading to 22.04.

22.10 is the latest version btw, 22.04 is just the latest version with longer support

@MarcoGorelli
Copy link
Member Author

yup, here it is #50115

WillAyd added a commit to WillAyd/pandas that referenced this pull request Dec 7, 2022
MarcoGorelli pushed a commit that referenced this pull request Dec 10, 2022
* Revert "CI try using ubuntu20.04 (#50113)"

This reverts commit 03a981a.

* removed dead cython code

* fix warning

* ci to ubuntu 22.04

* cython fixups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI warning is causing build to fail
3 participants