-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI try using ubuntu20.04 #50113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI try using ubuntu20.04 #50113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
BTW, I might be considering making a pre-commit hook to ban uses of latest versions of images from being used. There's not really much benefit to doing this, and we already pin when building wheels (I've been burned by this in the past, when Visual Studio 2017 was upgraded to Visual Studio 2019). |
Thanks - jobs are passing now, so let's merge to unblock all other PRs
Nice! I'm all for automation |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Can you open an issue? We should think about upgrading to 22.04. 22.10 is the latest version btw, 22.04 is just the latest version with longer support |
yup, here it is #50115 |
This reverts commit 03a981a.
trying to fix broken CI builds
closes #50112