BUG: datetime.date objects don't get parsed for non-ISO formats #50109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Dec 7, 2022
Comment on lines
+178
to
+181
| elif PyDate_Check(val): | ||
| iresult[i] = pydate_to_dt64(val, &dts) | ||
| check_dts_bounds(&dts) | ||
| continue |
There was a problem hiding this comment.
same as
Lines 544 to 547 in 7c0278e
There was a problem hiding this comment.
do we need to worry about found_naive? (i guess we dont currently in the tslib code?)
There was a problem hiding this comment.
Not sure we need to, datetime.dates can't have a timezone, so perhaps it's fine to just parse?
There was a problem hiding this comment.
OK to punt on this for now
MarcoGorelli
force-pushed
the
parse-date-in-strptime
branch
from
0ef8556 to
b707682
Compare
mroeschke
reviewed
Dec 7, 2022
mroeschke
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.