Skip to content

TST: Refactor test_subtracting_two_series_with_unordered_index_and_all_nan_index #49698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

shogohida
Copy link

@shogohida shogohida commented Nov 14, 2022

Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just create two tests testing both cases, no need to call specific functions for this I think

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Nov 16, 2022
shogohida and others added 2 commits November 23, 2022 02:32
@shogohida
Copy link
Author

Is my implementation correct?

d106b17

@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Dec 23, 2022
@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: Refactor test_subtracting_two_series_with_unordered_index_and_all_nan_index
3 participants