-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
TST: Refactor test_subtracting_two_series_with_unordered_index_and_all_nan_index
#49443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @phofl, I want to work on this! However, I'm not very sure how to refactor the test because I'm new to Pandas. Could you give me some advice? It would be really helpful |
It would be helpful to remove the parametrisation and split the content into two tests so that it is easier to read. But would be good to wait till the linked pr is merged, because it changed the behavior of the test |
take |
Thanks for your comment! Now I understand that I need to separate pandas/pandas/tests/indexing/multiindex/test_multiindex.py Lines 187 to 215 in a551f1b
|
Some tests failed but I wanted to make sure if my understanding is correct at first. Can you have a look? |
The test is hard to read and hard to understand. We should refactor it to make it more straightforward without those parametrizations. Pending #49442
The text was updated successfully, but these errors were encountered: