Modify precommit config yaml and change name of typing step to Typing + pylint.

[sudhansubhushanmishra]

Modify the pre-commit config.yml file and change name of step in code-checks.yml. Possible attempt to resolve #49526
Please provide feedback an I'd try to incorporate those changes.

[MarcoGorelli]

this isn't quite right, check the mypy hook for an example of the syntax

[sudhansubhushanmishra]

I'm sorry, are the changes ok now?

[MarcoGorelli]

should be fine, thanks!

[akx]

Beyond the inline comment, it's not quite clear why more pylint codes need to be disabled..?

[akx]

What are the implications of these changes?

[MarcoGorelli]

it'll run like the mypy one, only in CI

[MarcoGorelli]

Thanks @the-lazy-learner ! I just merged upstream/main, added pylint to the environment file, and added a couple more checks to the ignore list as pylint also has some dynamic checks which don't run when it's just a pre-commit hook, hope that's OK

[MarcoGorelli]

merging as the affected checks all pass

EDIT: github won't let me, let's see if #49538 solves this

[jorisvandenbossche]

@MarcoGorelli is there a reason to add pylint to the env file? The check is still run through pre-commit, which will make install it in its own env?

(although that's also the case for black et al, and those are also here, so it's all OK, just wondering)

[MarcoGorelli]

pylint can do some extra inference if it has everything built (hence a few extra checks that need to be turned off in this PR) - if it's only running in CI, then we might as well use the environment where pandas has been built (like we do for mypy, that one also has language: system)

[jorisvandenbossche]

Ah, I missed the language: system . Thanks for the explanation!

[MarcoGorelli]

🤔 though language: system is less reliable, so maybe this should still run in its own little env...yeah let's do that, then the risk of it annoying contributors / maintainers is reduced

[jorisvandenbossche]

BTW, there is an actual failure:

 pylint...................................................................Failed
- hook id: pylint
- exit code: 8

************* Module pandas.core.dtypes.concat
pandas/core/dtypes/concat.py:284:8: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise)

[MarcoGorelli]

BTW, there is an actual failure:

 pylint...................................................................Failed
- hook id: pylint
- exit code: 8

************* Module pandas.core.dtypes.concat
pandas/core/dtypes/concat.py:284:8: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise)

Yup, fixed in #49537

[MarcoGorelli]

A couple of us have had issues merging this one, not sure if the issue is on GitHub's side, but I've opened #49538 to take this forwards (and have kept @the-lazy-learner as the commit author)