Skip to content

CI: only run pylint in CI #49526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarcoGorelli opened this issue Nov 4, 2022 · 6 comments · Fixed by #49538
Closed

CI: only run pylint in CI #49526

MarcoGorelli opened this issue Nov 4, 2022 · 6 comments · Fixed by #49538
Labels
CI Continuous Integration good first issue

Comments

@MarcoGorelli
Copy link
Member

MarcoGorelli commented Nov 4, 2022

pylint is helping unearth some issues, but it's quite slow, especially for local development

as brought up on Slack by @jorisvandenbossche , let's just run it in CI instead

Task would be:

  1. in

- repo: https://github.com/pycqa/pylint
rev: v2.15.5
hooks:
- id: pylint

add

        language: system
        pass_filenames: false
        stages: [manual]
  1. modify the name of
    - name: Typing
    uses: pre-commit/[email protected]
    with:
    extra_args: --hook-stage manual --all-files
    if: ${{ steps.build.outcome == 'success' && always() }}
    to "Typing + pylint"
@MarcoGorelli MarcoGorelli added CI Continuous Integration good first issue labels Nov 4, 2022
@sudhansubhushanmishra
Copy link
Contributor

Could I attempt resolving this issue? I'm mostly a beginner as of now.
Also, for the part, do we need to add these to args?
Please point me in the right direction, it'd be a lot helpful if there was place to refer for the first yaml file's syntax.
Thank you @MarcoGorelli I look forward to many more future collaboration with the community.

@MarcoGorelli
Copy link
Member Author

sure, PRs welcome, here's the contributing guide https://pandas.pydata.org/docs/development/contributing.html

@sudhansubhushanmishra
Copy link
Contributor

By the way is it language_version instead of language?

@MarcoGorelli
Copy link
Member Author

no

@sudhansubhushanmishra
Copy link
Contributor

Oh sorry. I just realised that looking at https://pre-commit.com/

@sudhansubhushanmishra
Copy link
Contributor

Please provide feedback on the PR #49527 . I need to learn more about the processes I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration good first issue
Projects
None yet
2 participants