STYLE: fix some consider-using-enumerate pylint warnings #49214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moisan
changed the title
Moisan
force-pushed
the
enumerate_pylint
branch
from
96d8432 to
2b06d03
Compare
mroeschke
reviewed
Oct 20, 2022
pandas/core/array_algos/take.py
Outdated
| @@ -549,13 +549,11 @@ def _take_2d_multi_object( | |||
| out[row_mask, :] = fill_value | |||
| if col_needs: | |||
| out[:, col_mask] = fill_value | |||
| for i in range(len(row_idx)): | |||
| for i, u_ in enumerate(row_idx): | |||
| u_ = row_idx[i] | |||
There was a problem hiding this comment.
This u_ shouldn' be needed anymore I think
These should be refactored if possible |
pandas/core/reshape/reshape.py
Outdated
Comment on lines
638
to
640
| level.reverse() | ||
| while level: | ||
| lev = level.pop() |
There was a problem hiding this comment.
would lev = level.pop(0) (without level.reverse) work?
mroeschke
approved these changes
Oct 21, 2022
MarcoGorelli
approved these changes
Oct 21, 2022
Comment on lines
-639
to
+642
| for index in range(len(level)): | ||
| lev = level[index] | ||
| while level: | ||
| lev = level.pop(0) | ||
| result = stack(result, lev, dropna=dropna) | ||
| # Decrement all level numbers greater than current, as these | ||
| # have now shifted down by one | ||
| updated_level = [] | ||
| for other in level: | ||
| if other > lev: | ||
| updated_level.append(other - 1) | ||
| else: | ||
| updated_level.append(other) | ||
| level = updated_level | ||
| level = [v if v <= lev else v - 1 for v in level] |
There was a problem hiding this comment.
Nice! Looks fine, and I ran
$ cat f.py
import numpy as np
for _ in range(10):
original_level = np.random.randint(0, 8, size=9)
main_lev_sequence = []
level = [i for i in original_level]
for index in range(len(level)):
lev = level[index]
main_lev_sequence.append(lev)
updated_level = []
for other in level:
if other > lev:
updated_level.append(other - 1)
else:
updated_level.append(other)
level = updated_level
branch_lev_sequence = []
level = [i for i in original_level]
while level:
lev = level.pop(0)
branch_lev_sequence.append(lev)
level = [v if v <= lev else v - 1 for v in level]
assert main_lev_sequence == branch_lev_sequence
to check, which worked
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Oct 21, 2022
…49214) * STYLE: fix some consider-using-enumerate pylint errors * fixup! STYLE: fix some consider-using-enumerate pylint errors * fixup! fixup! STYLE: fix some consider-using-enumerate pylint errors * fixup! fixup! fixup! STYLE: fix some consider-using-enumerate pylint errors * fixup! fixup! fixup! fixup! STYLE: fix some consider-using-enumerate pylint errors
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…49214) * STYLE: fix some consider-using-enumerate pylint errors * fixup! STYLE: fix some consider-using-enumerate pylint errors * fixup! fixup! STYLE: fix some consider-using-enumerate pylint errors * fixup! fixup! fixup! STYLE: fix some consider-using-enumerate pylint errors * fixup! fixup! fixup! fixup! STYLE: fix some consider-using-enumerate pylint errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #48855
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This covers some
consider-using-enumeratepylint warnings but not all them. The ones left are often using the index of the for-loop without accessing element of the list. Is that something we want to put an "ignore" tag on?