Skip to content

Commit 2b06d03

Browse files
committed
STYLE: fix some consider-using-enumerate pylint errors
1 parent fe93a83 commit 2b06d03

File tree

7 files changed

+20
-22
lines changed

7 files changed

+20
-22
lines changed

pandas/core/array_algos/take.py

+2-4
Original file line numberDiff line numberDiff line change
@@ -549,13 +549,11 @@ def _take_2d_multi_object(
549549
out[row_mask, :] = fill_value
550550
if col_needs:
551551
out[:, col_mask] = fill_value
552-
for i in range(len(row_idx)):
552+
for i, u_ in enumerate(row_idx):
553553
u_ = row_idx[i]
554554

555555
if u_ != -1:
556-
for j in range(len(col_idx)):
557-
v = col_idx[j]
558-
556+
for j, v in enumerate(col_idx):
559557
if v != -1:
560558
out[i, j] = arr[u_, v]
561559

pandas/core/arrays/interval.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -1438,11 +1438,11 @@ def __array__(self, dtype: NpDtype | None = None) -> np.ndarray:
14381438
closed = self.closed
14391439

14401440
result = np.empty(len(left), dtype=object)
1441-
for i in range(len(left)):
1441+
for i, left_value in enumerate(left):
14421442
if mask[i]:
14431443
result[i] = np.nan
14441444
else:
1445-
result[i] = Interval(left[i], right[i], closed)
1445+
result[i] = Interval(left_value, right[i], closed)
14461446
return result
14471447

14481448
def __arrow_array__(self, type=None):

pandas/io/formats/printing.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -426,17 +426,17 @@ def best_len(values: list[str]) -> int:
426426
summary = ""
427427
line = space2
428428

429-
for max_items in range(len(head)):
430-
word = head[max_items] + sep + " "
429+
for head_value in head:
430+
word = head_value + sep + " "
431431
summary, line = _extend_line(summary, line, word, display_width, space2)
432432

433433
if is_truncated:
434434
# remove trailing space of last line
435435
summary += line.rstrip() + space2 + "..."
436436
line = space2
437437

438-
for max_items in range(len(tail) - 1):
439-
word = tail[max_items] + sep + " "
438+
for tail_item in tail[:-1]:
439+
word = tail_item + sep + " "
440440
summary, line = _extend_line(summary, line, word, display_width, space2)
441441

442442
# last value: no sep added + 1 space of width used for trailing ','

pandas/tests/arrays/sparse/test_indexing.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
class TestGetitem:
1616
def test_getitem(self):
1717
dense = arr.to_dense()
18-
for i in range(len(arr)):
19-
tm.assert_almost_equal(arr[i], dense[i])
18+
for i, value in enumerate(arr):
19+
tm.assert_almost_equal(value, dense[i])
2020
tm.assert_almost_equal(arr[-i], dense[-i])
2121

2222
def test_getitem_arraylike_mask(self):

pandas/tests/frame/methods/test_replace.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -873,8 +873,8 @@ def test_replace_input_formats_listlike(self):
873873
values = [-2, -1, "missing"]
874874
result = df.replace(to_rep, values)
875875
expected = df.copy()
876-
for i in range(len(to_rep)):
877-
return_value = expected.replace(to_rep[i], values[i], inplace=True)
876+
for rep, value in zip(to_rep, values):
877+
return_value = expected.replace(rep, value, inplace=True)
878878
assert return_value is None
879879
tm.assert_frame_equal(result, expected)
880880

@@ -901,8 +901,8 @@ def test_replace_input_formats_scalar(self):
901901
to_rep = [np.nan, 0, ""]
902902
result = df.replace(to_rep, -1)
903903
expected = df.copy()
904-
for i in range(len(to_rep)):
905-
return_value = expected.replace(to_rep[i], -1, inplace=True)
904+
for rep in to_rep:
905+
return_value = expected.replace(rep, -1, inplace=True)
906906
assert return_value is None
907907
tm.assert_frame_equal(result, expected)
908908

pandas/tests/indexes/multi/test_indexing.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -884,9 +884,9 @@ def test_pyint_engine():
884884
# keys would collide; if truncating the last levels, the fifth and
885885
# sixth; if rotating bits rather than shifting, the third and fifth.
886886

887-
for idx in range(len(keys)):
887+
for idx, key_value in enumerate(keys):
888888
index = MultiIndex.from_tuples(keys)
889-
assert index.get_loc(keys[idx]) == idx
889+
assert index.get_loc(key_value) == idx
890890

891891
expected = np.arange(idx + 1, dtype=np.intp)
892892
result = index.get_indexer([keys[i] for i in expected])

pandas/tests/io/test_stata.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -774,15 +774,15 @@ def test_big_dates(self, datapath):
774774
mm = [0, 0, 59, 0, 0, 0]
775775
ss = [0, 0, 59, 0, 0, 0]
776776
expected = []
777-
for i in range(len(yr)):
777+
for year, month, day, hour, minute, second in zip(yr, mo, dd, hr, mm, ss):
778778
row = []
779779
for j in range(7):
780780
if j == 0:
781-
row.append(datetime(yr[i], mo[i], dd[i], hr[i], mm[i], ss[i]))
781+
row.append(datetime(year, month, day, hour, minute, second))
782782
elif j == 6:
783-
row.append(datetime(yr[i], 1, 1))
783+
row.append(datetime(year, 1, 1))
784784
else:
785-
row.append(datetime(yr[i], mo[i], dd[i]))
785+
row.append(datetime(year, month, day))
786786
expected.append(row)
787787
expected.append([pd.NaT] * 7)
788788
columns = [

0 commit comments

Comments
 (0)