CLN/TST: Remove testing ArrowExtensionArray in favor of extensions/test_arrow.py
#49000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Testing
mroeschke
changed the title
extensions/test_arrow.py
phofl
reviewed
Oct 11, 2022
|
|
||
|
|
||
| def test_is_bool_dtype(): | ||
| data = ArrowExtensionArray(pa.array([True, False, True])) |
phofl
approved these changes
Oct 13, 2022
|
thx @mroeschke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #46008
extension/arrow/test_timestamp.py: The original issue BUG: Cannot create third-party ExtensionArrays for datetime types #34986 (ExtensionDtypes with kind="M") is more-narrowly tested in BUG: is_datetime64tz_dtype shortcut only for DatetimeTZDtype #48640 and the DataFrame construction is tested inpandas/tests/extension/test_arrow.py::TestConstructorsasArrowDtype(pa.timestamp())has kind="M"extension/arrow/test_string.py: Moved test topandas/tests/extension/test_string.pyextension/arrow/test_bool.py: Movedtest_is_bool_dtypeandtest_basic_equalstoextensions/test_arrow.pyThe rest of the test appeared to be a subset of what is tested intest_arrow.py