Skip to content

REF: ArrowBackedExtensionArray #46008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbrockmendel opened this issue Feb 15, 2022 · 4 comments · Fixed by #49000
Closed

REF: ArrowBackedExtensionArray #46008

jbrockmendel opened this issue Feb 15, 2022 · 4 comments · Fixed by #49000
Labels
Arrow pyarrow functionality Enhancement

Comments

@jbrockmendel
Copy link
Member

We should refactor out parts of ArrowStringArray and tests.extension.arrow.arrays.ArrowExtensionArray that can be re-used for more general arrow-based EAs.

A couple of questions that came up in my first pass at this (cc @jorisvandenbossche):

  • Should the general case allow backing by either pa.Array or pa.ChunkedArray, or just pa.ChunkedArray?
  • ArrowStringArray.copy relies on immutability. Will that be the case in general? If not, how do we check for it?
  • Is the more verbose nbytes in ArrowExtensionArray more robust/correct than the one in ArrowStringArray?
  • Are the slightly-different _concat_same_type methods equivalent? Usable for the general case?
@jbrockmendel jbrockmendel added Enhancement Needs Triage Issue that has not been reviewed by a pandas team member labels Feb 15, 2022
@mroeschke mroeschke added Arrow pyarrow functionality and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Feb 16, 2022
@jbrockmendel
Copy link
Member Author

@xhochy is there anything worth upstreaming from fletcher? Or maybe fletcher is a better home for this?

@jbrockmendel jbrockmendel mentioned this issue Feb 21, 2022
Merged
This was referenced Jun 26, 2022
Open
Open
@mroeschke mroeschke mentioned this issue Oct 7, 2022
Merged
@jbrockmendel
Copy link
Member Author

@mroeschke closeable?

@mroeschke
Copy link
Member

Yeah will close with #49000

@xhochy
Copy link
Contributor

xhochy commented Oct 12, 2022

Looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Arrow pyarrow functionality Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CLN/TST: Remove testing ArrowExtensionArray in favor of extensions/test_arrow.py mroeschke/pandas
3 participants
@xhochy @jbrockmendel @mroeschke