Skip to content

Backport PR #48987 on branch 1.5.x (REG: Fix regression in assert_frame_equal for categorical and check_like) #48997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #48987: REG: Fix regression in assert_frame_equal for categorical and check_like

@lumberbot-app lumberbot-app bot added this to the 1.5.1 milestone Oct 7, 2022
@lumberbot-app lumberbot-app bot added Regression Functionality that used to work in a prior pandas version Testing pandas testing functions or related to the test suite labels Oct 7, 2022
@phofl
Copy link
Member

phofl commented Oct 7, 2022

Yikes this is tricky, the changes in safe_sort are not on 1.5.x

@phofl
Copy link
Member

phofl commented Oct 7, 2022

@mroeschke any opinion on back porting the safe sort improvement too? Basically we have to get a MultiIndex back from safe_sort. Not sure if there is another way around this.

@mroeschke
Copy link
Member

@mroeschke any opinion on back porting the safe sort improvement too? Basically we have to get a MultiIndex back from safe_sort. Not sure if there is another way around this.

Could you link the PR(s) that made the change(s) to safe_sort?

@phofl
Copy link
Member

phofl commented Oct 7, 2022

#48412 and (unfortunately) parts of #48498

We could revert the change that caused this, but since this was a bug fix, we would loose functionality

@mroeschke
Copy link
Member

IMO I think it's okay to backport both PRs. They seem fairly narrow toward what they fixed. I guess you can transfer that bug fix whatsnew note from 1.6.0 to 1.5.1.

@phofl
Copy link
Member

phofl commented Oct 7, 2022

I think I would prefer only back porting the algorithm part from the second one, the other one ties into a few other things we've done, is probably better to keep them together

@mroeschke
Copy link
Member

I think I would prefer only back porting the algorithm part from the second one, the other one ties into a few other things we've done, is probably better to keep them together

Okay sounds good.

@phofl phofl merged commit 0b4064d into pandas-dev:1.5.x Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Regression Functionality that used to work in a prior pandas version Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants