Skip to content

BUG: preserve DTA/TDA+timedeltalike scalar with mismatched resos #48923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 11, 2022

Conversation

jbrockmendel
Copy link
Member

Sits on top of #48918

@mroeschke mroeschke added Datetime Datetime data dtype Numeric Operations Arithmetic, Comparison, and Logical operations Timedelta Timedelta data type Non-Nano datetime64/timedelta64 with non-nanosecond resolution labels Oct 3, 2022
@jbrockmendel
Copy link
Member Author

Looks like I accidentally opened both this and #49015 for the same bug. After rebasing this is just an extra test that is worth keeping.

@mroeschke mroeschke added this to the 1.6 milestone Oct 11, 2022
@mroeschke mroeschke merged commit 28da588 into pandas-dev:main Oct 11, 2022
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the nano-arith-tdscalar branch October 11, 2022 17:57
@mroeschke mroeschke removed this from the 1.6 milestone Oct 13, 2022
@mroeschke mroeschke added this to the 2.0 milestone Oct 13, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
…das-dev#48923)

* BUG: Timedelta.__new__

* remove assertion

* GH refs

* API: Timedelta(td64_obj) retain resolution

* API: Timedelta constructor pytimedelta, Tick preserve reso

* STYLE: fix pylint style checks for inherit-non-class. (pandas-dev#48897)

* fix pylint for non-class-inherit and add pre-commit changes

* move ExtensionArraySupportsAnyAll to below ExtensionArray

* move if TYPE_CHECKING back up to line 94

* remove erroneous space

* BUG: preserve DTA/TDA+timedeltalike scalar with mismatched resos

* merge main

* remove debugging variable

Co-authored-by: Kostya Farber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype Non-Nano datetime64/timedelta64 with non-nanosecond resolution Numeric Operations Arithmetic, Comparison, and Logical operations Timedelta Timedelta data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants