API: Timedelta constructor pytimedelta, Tick preserve reso #48918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
@mroeschke getting this and/or the astype one in would let me have a productive weekend |
mroeschke
reviewed
Oct 8, 2022
| @@ -1706,7 +1707,13 @@ class Timedelta(_Timedelta): | |||
| value = parse_timedelta_string(value) | |||
| value = np.timedelta64(value) | |||
| elif PyDelta_Check(value): | |||
| value = convert_to_timedelta64(value, 'ns') | |||
| # pytimedelta object -> microsecond resolution | |||
There was a problem hiding this comment.
When the non-nano resolution docs are written, might be good to mention that datetime.timedeltas now default to microsecond resolution?
mroeschke
approved these changes
Oct 8, 2022
|
Thanks @jbrockmendel |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…v#48918) * BUG: Timedelta.__new__ * remove assertion * GH refs * API: Timedelta(td64_obj) retain resolution * API: Timedelta constructor pytimedelta, Tick preserve reso * remove debugging variable * remove duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sits on top of #48910