Fix: Reanme duplicate function names in unittests #48906
Conversation
FloHofstetter
commented
Oct 1, 2022
•
FloHofstetter
commented
- xref STYLE fix pylint issues #48855 - one of many style checks, still needs work.
- All code checks passed.
| @@ -437,28 +437,28 @@ def check_col(key, name, size): | |||
|
|
|||
| with ensure_clean_store(setup_path) as store: | |||
|
|
|||
| def check_col(key, name, size): | |||
| def check_col_1(key, name, size): | |||
| assert getattr(store.get_storer(key).table.description, name).itemsize, size | |||
There was a problem hiding this comment.
Thanks for doing this @FloHofstetter !
🤔 what an odd function...I wonder if it was meant to be
assert getattr(store.get_storer(key).table.description, name).itemsize == size
I'll look through the history to see if there's any clues
There was a problem hiding this comment.
Indeed 😄
https://github.com/pandas-dev/pandas/pull/16169/files
def check_col(key, name, size):
- self.assertEqual(getattr(store.get_storer(
- key).table.description, name).itemsize, size)
+ assert getattr(store.get_storer(key)
+ .table.description, name).itemsize, sizecc @gfyoung this is typo right? Just double-checking, in case you remember
Looks like this should be the same as check_col_0 above, can we just keep that one as check_col and remove this one @FloHofstetter ?
There was a problem hiding this comment.
Yep, that indeed looks like a typo @MarcoGorelli
| @@ -437,28 +437,28 @@ def check_col(key, name, size): | |||
|
|
|||
| with ensure_clean_store(setup_path) as store: | |||
|
|
|||
| def check_col(key, name, size): | |||
| def check_col_1(key, name, size): | |||
| assert getattr(store.get_storer(key).table.description, name).itemsize, size | |||
There was a problem hiding this comment.
Indeed 😄
https://github.com/pandas-dev/pandas/pull/16169/files
def check_col(key, name, size):
- self.assertEqual(getattr(store.get_storer(
- key).table.description, name).itemsize, size)
+ assert getattr(store.get_storer(key)
+ .table.description, name).itemsize, sizecc @gfyoung this is typo right? Just double-checking, in case you remember
Looks like this should be the same as check_col_0 above, can we just keep that one as check_col and remove this one @FloHofstetter ?
|
Hi @MarcoGorelli, I don't get how to rerun the failed action... Do I have permission to re-trigger? -- Flo |
|
it's unrelated, don't worry about it |
* Fix: Reanme duplicate function names in unittests * Fix: Reanme duplicate function names in unittests * Fix: Reanme duplicate function names in unittests
