Skip to content

REF: helpers to de-duplicate datetimelike arithmetic #48844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 29, 2022
Merged

REF: helpers to de-duplicate datetimelike arithmetic #48844

merged 2 commits into from
Sep 29, 2022

Conversation

jbrockmendel
Copy link
Member

1-2 more PRs after this using these helpers

@jbrockmendel jbrockmendel mentioned this pull request Sep 29, 2022
Merged
@mroeschke mroeschke added Refactor Internal refactoring of code Datetime Datetime data dtype Numeric Operations Arithmetic, Comparison, and Logical operations Timedelta Timedelta data type labels Sep 29, 2022
mroeschke
mroeschke requested changes Sep 29, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typing failures: https://github.com/pandas-dev/pandas/actions/runs/3148299272/jobs/5131019981

@jbrockmendel
Copy link
Member Author

Typing failures: https://github.com/pandas-dev/pandas/actions/runs/3148299272/jobs/5131019981

merged master. hopefully that'll do it since the other one is OK

@jbrockmendel
Copy link
Member Author

green

@mroeschke mroeschke added this to the 1.6 milestone Sep 29, 2022
@mroeschke mroeschke merged commit 8f26ab7 into pandas-dev:main Sep 29, 2022
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the ref-checked_add-period branch September 29, 2022 23:46
@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@jbrockmendel @noatamir
REF: helpers to de-duplicate datetimelike arithmetic (pandas-dev#48844)
8c9e2f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Datetime Datetime data dtype Numeric Operations Arithmetic, Comparison, and Logical operations Refactor Internal refactoring of code Timedelta Timedelta data type
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @mroeschke