Skip to content

ENH: Added xlsxwriter as an ExcelWriter option. #4847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

ENH: Added xlsxwriter as an ExcelWriter option. #4847

wants to merge 10 commits into from

Conversation

jmcnamara
Copy link
Contributor

Added xlsxwriter as an optional writer engine. Issue #4542.

@jmcnamara
Copy link
Contributor Author

Merged comments from #4739 but created new PR based on @jtratner's refactoring of excel.py.

Note, this PR doesn't include test cases due to fact that test_excel.py has also been heavily refactored but isn't yet merged (#4844). Once, those cases are merged to master I'll rebase and update this PR. I've added test_excel.py tests on a separate branch and they pass local and TravisCI tests.

TST: Cleanup Excel tests to make it easier to add and test additional writers
@jtratner
Copy link
Contributor

@jmcnamara I merged the other branch,

@@ -4,3 +4,4 @@ python-dateutil==1.5
pytz==2013b
http://www.crummy.com/software/BeautifulSoup/bs4/download/4.2/beautifulsoup4-4.2.0.tar.gz
html5lib==1.0b2
xlsxwriter==0.4.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think 2.6 has any of the others, so this doesn't need to be added here.

@jtratner
Copy link
Contributor

btw - if you need to change the ordering of how the cells are formatted (e.g., so that it yields cells in a different order or something), you could move the cell formatting to a method on ExcelWriter and then overwrite that in XlsxwriterWriter (or whatever you are calling it). I recall you saying something about that in regards to performance. (and then just pass additional keyword arguments to write_cells, etc.)

@@ -1,12 +1,7 @@
# pylint: disable=E1101
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like I fubared the rebase for this file since the majority of these changes are from #4844 which is already in master. I'll look into it and see if I can fix it.

@jmcnamara
Copy link
Contributor Author

I can't seem to fix this cleanly. I'm going to close the PR, rebase and squash the commits.

@jmcnamara jmcnamara closed this Sep 16, 2013
@hayd
Copy link
Contributor

hayd commented Mar 19, 2014

What's the current status of other engines for excel?

@jmcnamara
Copy link
Contributor Author

I made an attempt to add pyexcelerate as a writer engine in PR #5128.

That stalled however and was eventually rejected. See the comments at the end of the PR for the reasons.

Apart from that, there aren't currently, to the best of my knowledge, any Excel reader/writers that would be worth adding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants