-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: Added xlsxwriter as an ExcelWriter option. #4847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added xlsxwriter as an optional writer engine. Issue #4542.
Merged comments from #4739 but created new PR based on @jtratner's refactoring of Note, this PR doesn't include test cases due to fact that |
TST: Cleanup Excel tests to make it easier to add and test additional writers
@jmcnamara I merged the other branch, |
@@ -4,3 +4,4 @@ python-dateutil==1.5 | |||
pytz==2013b | |||
http://www.crummy.com/software/BeautifulSoup/bs4/download/4.2/beautifulsoup4-4.2.0.tar.gz | |||
html5lib==1.0b2 | |||
xlsxwriter==0.4.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think 2.6 has any of the others, so this doesn't need to be added here.
btw - if you need to change the ordering of how the cells are formatted (e.g., so that it yields cells in a different order or something), you could move the cell formatting to a method on |
Added xlsxwriter as an optional writer engine. Issue #4542.
… into enh_xlsxwriter_refactor
@@ -1,12 +1,7 @@ | |||
# pylint: disable=E1101 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like I fubared the rebase for this file since the majority of these changes are from #4844 which is already in master. I'll look into it and see if I can fix it.
I can't seem to fix this cleanly. I'm going to close the PR, rebase and squash the commits. |
What's the current status of other engines for excel? |
I made an attempt to add pyexcelerate as a writer engine in PR #5128. That stalled however and was eventually rejected. See the comments at the end of the PR for the reasons. Apart from that, there aren't currently, to the best of my knowledge, any Excel reader/writers that would be worth adding. |
Added xlsxwriter as an optional writer engine. Issue #4542.