TST: Cleanup Excel tests to make it easier to add and test additional writers #4844
+225
−302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jmcnamara - this should make it much easier for you to add and test xlsxwriter. Just follow the pattern for OpenpyxlTests and XlwtTests and you should be good. |
|
For those interested: this doesn't add or remove tests, just makes it much easier to add new writers and new writer tests. |
|
and preserves skip output: |
|
@jtratner That looks good. It will make adding tests for new engines very clean and straightforward. |
jtratner
added a commit
that referenced
this pull request
Sep 15, 2013
TST: Cleanup Excel tests to make it easier to add and test additional writers
|
@jtratner How do you set the writer engine from a subclass? Should it be set up via Or am I missing something more direct. |
|
@jmcnamara oh...very good point. wasn't thinking, give me a second, I'll put in a patch for you so you can get it to work. |
|
@jmcnamara you can just add it to your PR...not going to do a separate pull request. |
|
You can run the following to get the patch below: Or you can copy it in yourself by saving this to a file and using diff --git a/pandas/io/tests/test_excel.py b/pandas/io/tests/test_excel.py
index 0053602..047f10c 100644
--- a/pandas/io/tests/test_excel.py
+++ b/pandas/io/tests/test_excel.py
@@ -16,6 +16,7 @@ from pandas.io.excel import (
register_writer
)
from pandas.util.testing import ensure_clean
+from pandas.core.config import set_option, get_option
import pandas.util.testing as tm
import pandas as pd
@@ -277,6 +278,12 @@ class ExcelWriterBase(SharedItems):
def setUp(self):
self.check_skip()
super(ExcelWriterBase, self).setUp()
+ self.option_name = 'io.excel.%s.writer' % self.ext
+ self.prev_engine = get_option(self.option_name)
+ set_option(self.option_name, self.engine_name)
+
+ def tearDown(self):
+ set_option(self.option_name, self.prev_engine)
def test_excel_sheet_by_name_raise(self):
_skip_if_no_xlrd()
@@ -790,6 +797,7 @@ class ExcelWriterBase(SharedItems):
class OpenpyxlTests(ExcelWriterBase, unittest.TestCase):
ext = 'xlsx'
+ engine_name = 'openpyxl'
check_skip = staticmethod(_skip_if_no_openpyxl)
def test_to_excel_styleconverter(self):
@@ -820,6 +828,7 @@ class OpenpyxlTests(ExcelWriterBase, unittest.TestCase):
class XlwtTests(ExcelWriterBase, unittest.TestCase):
ext = 'xls'
+ engine_name = 'xlwt'
check_skip = staticmethod(_skip_if_no_xlwt)
def test_to_excel_styleconverter(self): |
|
@jmcnamara so obviously, once you integrate, just set |
|
@jtratner Got it Jeff. Thanks. Your refactoring work on this and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.