Skip to content

TST: to_numeric(large_float, downcast=float) isn't lossy #48372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2022
Merged

TST: to_numeric(large_float, downcast=float) isn't lossy #48372

merged 1 commit into from
Sep 2, 2022

Conversation

mroeschke
Copy link
Member

Fixed by #43710 but adding an additional test.

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Dtype Conversions Unexpected or buggy dtype conversions labels Sep 2, 2022
@mroeschke mroeschke added this to the 1.6 milestone Sep 2, 2022
@mroeschke mroeschke merged commit f0fff8c into pandas-dev:main Sep 2, 2022
@mroeschke mroeschke deleted the tst/to_numeric_downcast branch September 2, 2022 21:26
@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@mroeschke @noatamir
TST: to_numeric(large_float, downcast=float) isn't lossy (pandas-dev#…
75abc6b 
…48372)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfyoung gfyoung gfyoung approved these changes

Assignees
No one assigned
Labels
Dtype Conversions Unexpected or buggy dtype conversions Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

to_numeric(..., downcast='float') is too aggressive
2 participants
@mroeschke @gfyoung