ENH: Add equivalence test for float in to_numeric() GH43693 #43710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
jbencina
force-pushed
the
jbencina-43693
branch
2 times, most recently
from
b0dfbaa to
3d57ec1
Compare
jbencina
force-pushed
the
jbencina-43693
branch
from
3d57ec1 to
5879125
Compare
jbencina
force-pushed
the
jbencina-43693
branch
from
5879125 to
6a037b1
Compare
jreback
added
Numeric Operations
|
@jbencina can you move the note, this looks good |
jreback
requested changes
Jan 16, 2022
jbencina
force-pushed
the
jbencina-43693
branch
from
6a037b1 to
9f9eb18
Compare
|
@jreback Moved the change to V1.5.0. Not sure why this PR has trouble with the CI checks, but I don't think it's related to my code (eg. Azure timing out) |
jreback
approved these changes
Jan 17, 2022
|
thanks @jbencina |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents issues where float64 arrays would be downcast to float32 arrays even if the values were out of range for float32. An equivalence check is performed to ensure all values are equal to 7 significant digits. If this fails, the original float64 is retained. This behavior is consistent with int where downcasting is not performed if the integer is out of bounds.
Pre Change:
Post Change: