Upgrade codespell version and fix misspelled words #48364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lucasdamo
commented
Sep 2, 2022
lucasdamo
commented
- closes STYLE: upgrade codespell #48349
lucasdamo
commented
Sep 2, 2022
MarcoGorelli
suggested changes
Sep 2, 2022
lucasdamo
commented
Sep 2, 2022
| cls.ro = deepcopy(getattr(cls.cf, "_registered_options")) | ||
| cls._global_config = deepcopy(getattr(cls.cf, "_global_config")) | ||
| cls._deprecated_options = deepcopy(getattr(cls.cf, "_deprecated_options")) | ||
| cls._registered_options = deepcopy(getattr(cls.cf, "_registered_options")) |
There was a problem hiding this comment.
Needed to change cls.ro and took the liberty to do the same with the others to keep a standard
lucasdamo
commented
Sep 2, 2022
setup.cfg
Outdated
| @@ -178,7 +178,7 @@ exclude = | |||
| doc/source/getting_started/comparison/includes/*.rst | |||
|
|
|||
| [codespell] | |||
| ignore-words-list = ba,blocs,coo,hist,nd,sav,ser,bu,ro,recuse,fromm | |||
There was a problem hiding this comment.
removing ba from the list didn't interfere with codespell checks
lucasdamo
commented
Sep 2, 2022
setup.cfg
Outdated
| @@ -178,7 +178,7 @@ exclude = | |||
| doc/source/getting_started/comparison/includes/*.rst | |||
|
|
|||
| [codespell] | |||
| ignore-words-list = ba,blocs,coo,hist,nd,sav,ser,bu,ro,recuse,fromm | |||
There was a problem hiding this comment.
@MarcoGorelli created a PR to CodeSpell, but for now should we keep recuse in Pandas ignore list?
lucasdamo
force-pushed
the
issue#48349CodeSpellUpgrade
branch
from
da0d531 to
7574fc2
Compare
|
Hey @MarcoGorelli, thanks so much for guiding me through this issue. I did a rebase to update this PR with latest commits on pandas, not sure if it was the right way. Do i have to do anything else so it gets merged? |
|
that's all thanks, I'll just leave it open a bit in case others have comments |
mroeschke
approved these changes
Sep 6, 2022
|
Thanks @lucasdamo. Very nice |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* Upgrade codespell version and fix misspelled words * Comply with PR comment's requested changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.