Skip to content

STYLE: upgrade codespell #48349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarcoGorelli opened this issue Sep 1, 2022 · 4 comments · Fixed by #48364
Closed

STYLE: upgrade codespell #48349

MarcoGorelli opened this issue Sep 1, 2022 · 4 comments · Fixed by #48364
Assignees
Labels
Code Style Code style, linting, code_checks good first issue

Comments

@MarcoGorelli
Copy link
Member

Task here is:

  • in
    - repo: https://github.com/codespell-project/codespell
    rev: v2.1.0
    hooks:
    - id: codespell
    types_or: [python, rst, markdown]
    , change the version to the latest available v2.2.1
  • run pre-commit run codespell --all-files. you should see something like
codespell...............................................................................................Failed
- hook id: codespell
- exit code: 65

pandas/tests/arrays/string_/test_string.py:185: bu ==> by
pandas/tests/config/test_config.py:19: ro ==> to, row, rob, rod, roe, rot
pandas/tests/config/test_config.py:36: ro ==> to, row, rob, rod, roe, rot
web/pandas/about/governance.md:186: recuse ==> recurse
pandas/io/parsers/python_parser.py:1275: fromm ==> from
pandas/io/parsers/python_parser.py:1275: fromm ==> from
pandas/tests/arrays/categorical/test_constructors.py:453: Hastable ==> Hashtable
pandas/core/resample.py:1048: coulmns ==> columns
pandas/io/formats/style.py:831: highlighed ==> highlighted
  • fixup these errors
  • check that pre-commit run codespell --all-files passes
  • open a PR
@jbrockmendel
Copy link
Member

web/pandas/about/governance.md:186: recuse ==> recurse

Looks like this one is correct as is

@lucasdamo
Copy link
Contributor

take

@prakhar-198
Copy link

take

@lucasdamo
Copy link
Contributor

lucasdamo commented Sep 2, 2022

This is my first pull request on pandas and on a large project like this one, if someone could double check it please, especially the commit message, formatting and so on...

I could not find a way to ignore errors on a per line/per file basis, if there is a way of doing so please tell me so I can improve this commit.

@prakhar-198 prakhar-198 removed their assignment Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants