BUG: MultiIndex.append not checking names for equality #48288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Aug 29, 2022
Co-authored-by: Matthew Roeschke <[email protected]>
mroeschke
reviewed
Aug 29, 2022
|
Added test and also fixed an internal bug in pivot_table creating missmatches in Index names |
mroeschke
reviewed
Aug 29, 2022
mroeschke
approved these changes
Aug 30, 2022
|
Thanks @phofl |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
) * BUG: MultiIndex.append not checking names for equality * BUG: MultiIndex.append not checking names for equality * Update doc/source/whatsnew/v1.6.0.rst Co-authored-by: Matthew Roeschke <[email protected]> * Add test and fix bug * Improve name checking Co-authored-by: Matthew Roeschke <[email protected]>
zhengruifeng
pushed a commit
to apache/spark
that referenced
this pull request
Sep 5, 2023
### What changes were proposed in this pull request? This PR proposes to fix the behavior of `MultiIndex.append` to do not checking names. ### Why are the changes needed? To match the behavior with pandas according to pandas-dev/pandas#48288 ### Does this PR introduce _any_ user-facing change? <!-- Note that it means *any* user-facing change including all aspects such as the documentation fix. If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible. If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master. If no, write 'No'. --> Yes, the behavior is changed to match with pandas: **Testing data** ```python >>> psmidx1 MultiIndex([('a', 'x', 1), ('b', 'y', 2), ('c', 'z', 3)], names=['x', 'y', 'z']) >>> psmidx2 MultiIndex([('a', 'x', 1), ('b', 'y', 2), ('c', 'z', 3)], names=['p', 'q', 'r']) ``` **Before** ```python >>> psmidx1.append(psmidx2) MultiIndex([('a', 'x', 1), ('b', 'y', 2), ('c', 'z', 3), ('a', 'x', 1), ('b', 'y', 2), ('c', 'z', 3)], names=['x', 'y', 'z']) ``` **After** ```python >>> psmidx1.append(psmidx2) MultiIndex([('a', 'x', 1), ('b', 'y', 2), ('c', 'z', 3), ('a', 'x', 1), ('b', 'y', 2), ('c', 'z', 3)], ) ``` ### How was this patch tested? <!-- If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks. --> Fix the existing UTs. ### Was this patch authored or co-authored using generative AI tooling? <!-- If generative AI tooling has been used in the process of authoring this patch, please include the phrase: 'Generated-by: ' followed by the name of the tool and its version. If no, write 'No'. Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details. --> No. Closes #42787 from itholic/SPARK-43241. Authored-by: Haejoon Lee <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.