Skip to content

CI: add warning when not in pandas dev and running stubtest #48267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 26, 2022
Merged

CI: add warning when not in pandas dev and running stubtest #48267

merged 5 commits into from
Aug 26, 2022

Conversation

ambujpawar
Copy link
Contributor

@ambujpawar ambujpawar commented Aug 26, 2022 •
edited
Loading

@ambujpawar ambujpawar changed the title add warning when not in pandas dev and running stubtest CI: add warning when not in pandas dev and running stubtest Aug 26, 2022
@ambujpawar ambujpawar marked this pull request as ready for review August 26, 2022 11:30
mroeschke
mroeschke reviewed Aug 26, 2022
View reviewed changes
@mroeschke mroeschke added CI Continuous Integration Typing type annotations, mypy/pyright type checking Warnings Warnings that appear or should be added to pandas labels Aug 26, 2022
@mroeschke mroeschke added this to the 1.6 milestone Aug 26, 2022
@ambujpawar
Copy link
Contributor Author

Thanks for the review. I resolved the comments you mentioned however, I noticed that the link you posted doesn't include the command to skip stubtest over here compared to the one we have over here

Perhaps, there needs to be another task created for it? Or is it being done in another PR?

@ambujpawar ambujpawar requested a review from mroeschke August 26, 2022 19:26
@mroeschke
Copy link
Member

Thanks for the review. I resolved the comments you mentioned however, I noticed that the link you posted doesn't include the command to skip stubtest over here compared to the one we have over here

Perhaps, there needs to be another task created for it? Or is it being done in another PR?

The doc updates in #48240 will be reflected on the website soon. We have a CI job that updates the docs (will be applied to versions >= 1.5)

@mroeschke mroeschke merged commit 9757d1f into pandas-dev:main Aug 26, 2022
@mroeschke
Copy link
Member

Thanks @ambujpawar

@ambujpawar ambujpawar deleted the 48260_improve_warning_running_stubtest branch August 27, 2022 05:40
@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@ambujpawar @noatamir
CI: add warning when not in pandas dev and running stubtest (pandas-d…
1574e67 
…ev#48267)

* add warning when not in pandas dev and running stubtest

* add url to the warning

* add trailing underscore in version

* Format the warning message

* resolve review comments

Co-authored-by: Ambuj Pawar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration Typing type annotations, mypy/pyright type checking Warnings Warnings that appear or should be added to pandas
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

CI: Improve warning when no pandas dev version installed when running stubtest
2 participants
@ambujpawar @mroeschke