Skip to content

CI: Improve warning when no pandas dev version installed when running stubtest #48260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
phofl opened this issue Aug 25, 2022 · 5 comments · Fixed by #48267
Closed

CI: Improve warning when no pandas dev version installed when running stubtest #48260

phofl opened this issue Aug 25, 2022 · 5 comments · Fixed by #48267
Assignees
@ambujpawar
Labels
CI Continuous Integration good first issue Typing type annotations, mypy/pyright type checking
Milestone
2.0

Comments

@phofl
Copy link
Member

phofl commented Aug 25, 2022

see #48240 (review)
@phofl phofl added CI Continuous Integration good first issue Typing type annotations, mypy/pyright type checking labels Aug 25, 2022
@phofl phofl changed the title CI: Improve warning when no pandas dev version installed when running stubbiest CI: Improve warning when no pandas dev version installed when running stubtest Aug 25, 2022
@samrao1997
Copy link
Contributor

@phofl Could you explain what the #current condition would be if pandas version is false?

@mroeschke
Copy link
Member

#current condition just means the logic that already exists in that if block

@ambujpawar
Copy link
Contributor

This looks something I can do. Can I take this up?

@phofl
Copy link
Member Author

phofl commented Aug 26, 2022

Sure

@ambujpawar
Copy link
Contributor

take

@ambujpawar ambujpawar mentioned this issue Aug 26, 2022
Merged
2 tasks
@phofl phofl added this to the 1.6 milestone Aug 27, 2022
@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ambujpawar ambujpawar

Labels
CI Continuous Integration good first issue Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

CI: add warning when not in pandas dev and running stubtest ambujpawar/pandas
4 participants
@mroeschke @ambujpawar @samrao1997 @phofl