-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
WEB: Use mambaforge for the getting started installation instructions? #48220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Install either `Anaconda <https://www.anaconda.com/products/individual>`_, `miniconda | ||
<https://docs.conda.io/en/latest/miniconda.html>`_, or `miniforge <https://github.com/conda-forge/miniforge>`_ | ||
* Make sure your conda is up to date (``conda update conda``) | ||
* Install `mamba <https://mamba.readthedocs.io/en/latest/index.html>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some references to conda
in the section above this one. Should those also be changed or maybe linked directly to this section for clarity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, good point, thanks
the mamba docs have conda activate
, but mamba activate
also works fine, I've replaced conda
with mamba
throughout to avoid confusion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd personally use this link to install mamba: https://github.com/conda-forge/miniforge#mambaforge
In my opinion this is what users should use, and it's not so obvious to find. Users may end up installing Anaconda, to then install mamba... which doesn't sound ideal.
But if you have a preference for the mamba home docs, also fine with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah agree that that's what people should use - it's the first link to show up on https://mamba.readthedocs.io/en/latest/installation.html , so let's link that (which'll probably be the most up-to-date reference)?
@datapythonista seeing as you'd opened the issue - any objections here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MarcoGorelli for working on this, nice improvement. Left couple of ideas, but happy to get this merged regardless.
We've also got this page in the website that we should update: https://pandas.pydata.org/getting_started.html. But better in a separate PR, I can do it if you prefer.
* Install either `Anaconda <https://www.anaconda.com/products/individual>`_, `miniconda | ||
<https://docs.conda.io/en/latest/miniconda.html>`_, or `miniforge <https://github.com/conda-forge/miniforge>`_ | ||
* Make sure your conda is up to date (``conda update conda``) | ||
* Install `mamba <https://mamba.readthedocs.io/en/latest/index.html>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd personally use this link to install mamba: https://github.com/conda-forge/miniforge#mambaforge
In my opinion this is what users should use, and it's not so obvious to find. Users may end up installing Anaconda, to then install mamba... which doesn't sound ideal.
But if you have a preference for the mamba home docs, also fine with it.
|
||
# or with older versions of Anaconda: | ||
source activate pandas-dev | ||
mamba env create -f environment.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The -f environment.yml
is not needed. I remember someone wanted to have it anyway at that time (not sure why), but if that's not the case anymore, I'd remove it and make things simpler.
Thanks @MarcoGorelli. Happy to have the followups in another PR |
@meeseeksdev backport 1.5.x |
backporting as this doesn't show up in the docs |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
…rted installation instructions?
…rted installation instructions?
…llation instructions? (#49211) Co-authored-by: MarcoGorelli <>
…s? (pandas-dev#48220) * recommend mamba * replace conda with mamba * use mamba reference * remove unnecessary -f environment.yml
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.Also doing some other assorted minor doc changes whilst here