BUG: Reindex casting to object in certain situation #48190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Indexing
# Conflicts: # doc/source/whatsnew/v1.6.0.rst # pandas/tests/frame/methods/test_reindex.py
|
cc @mroeschke gentle ping Ci is green, forgot to remove 1.5 whatsnew |
mroeschke
reviewed
Sep 1, 2022
pandas/core/generic.py
Outdated
| @@ -5345,6 +5345,9 @@ def _needs_reindex_multi(self, axes, method, level) -> bool_t: | |||
| and method is None | |||
| and level is None | |||
| and not self._is_mixed_type | |||
| and not ( | |||
| len(self.dtypes) == 1 and is_extension_array_dtype(self.dtypes.iloc[0]) | |||
There was a problem hiding this comment.
Might be cleaner to define for DataFrame only? Although Series overrides _needs_reindex_multi to be False, self.dtypes for Series is a scalar
mroeschke
reviewed
Sep 2, 2022
mroeschke
approved these changes
Sep 2, 2022
Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Stumbled across this when doing #48185
Longterm we could support a mask in take_2d_multi