Skip to content

BUG: reindex using wrong fill value when indexing cols and index for uint dtypes #48185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 31, 2022
Merged

BUG: reindex using wrong fill value when indexing cols and index for uint dtypes #48185

merged 5 commits into from
Aug 31, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Aug 20, 2022 •
edited
Loading

Any reason why we are not compiling the cython algo for uint dtypes?

@phofl phofl added the Indexing Related to indexing on series/frames, not to indexes themselves label Aug 20, 2022
@phofl phofl mentioned this pull request Aug 21, 2022
Merged
5 tasks
@phofl
Copy link
Member Author

phofl commented Aug 31, 2022

cc @mroeschke gentle ping

@mroeschke mroeschke added this to the 1.6 milestone Aug 31, 2022
mroeschke
mroeschke reviewed Aug 31, 2022
View reviewed changes
pandas/tests/frame/methods/test_reindex.py Outdated
@@ -772,6 +772,16 @@ def test_reindex_fill_value(self):
expected = df.reindex(range(15)).fillna(0)
tm.assert_frame_equal(result, expected)

@pytest.mark.parametrize("dtype", ["uint8", "uint16", "uint32", "uint64"])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any_unsigned_int_numpy_dtype

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, good point

@mroeschke
Copy link
Member

LGTM. Feel free to merge on greenish

@phofl phofl merged commit d0268e7 into pandas-dev:main Aug 31, 2022
@phofl phofl deleted the 48184 branch August 31, 2022 21:04
@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@phofl @noatamir
BUG: reindex using wrong fill value when indexing cols and index for …
f7790c3 
…uint dtypes (pandas-dev#48185)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
2.0
2 participants
@phofl @mroeschke