WARN,TST check stacklevel for all warnings #47998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
MarcoGorelli
force-pushed
the
find-stack-level
branch
3 times, most recently
from
8541084 to
82ea9f5
Compare
mroeschke
added
Testing
MarcoGorelli
force-pushed
the
find-stack-level
branch
from
cf3b28d to
591b2bb
Compare
MarcoGorelli
commented
Aug 14, 2022
| @@ -107,7 +107,7 @@ def test_scatter_matrix_axis(self, pass_axis): | |||
| df = DataFrame(np.random.randn(100, 3)) | |||
|
|
|||
| # we are plotting multiples on a sub-plot | |||
| with tm.assert_produces_warning(UserWarning, raise_on_extra_warnings=True): | |||
There was a problem hiding this comment.
raise_on_extra_warnings=True is the default, so removing it
Comment on lines
+662
to
665
| with tm.assert_produces_warning(UserWarning, check_stacklevel=False): | ||
| axes = _check_plot_works( | ||
| df.hist, column="height", by=df.gender, layout=(2, 1) | ||
| ) |
There was a problem hiding this comment.
Separately it'd be good to have _check_plot_works_check_warnings (analogous to parser.read_csv_check_warnings), but for now I'm just ignoring the stacklevel check
mroeschke
reviewed
Aug 16, 2022
|
Should be possible eventually, but at the moment there are some places where it needs setting manually for it to work, e.g. pandas/pandas/compat/pickle_compat.py Line 108 in a6aaeb6 It looks like there, the going back up the frames temporarily brings us into the standard library: (Pdb) frame
<frame at 0x7f87356b1b20, file '/home/marco/pandas-marco/pandas/compat/pickle_compat.py', line 92, code __new__>
(Pdb) p frame.f_back
<frame at 0x7f873569f7c0, file '/home/marco/pandas-marco/pandas/compat/pickle_compat.py', line 231, code load_newobj>
(Pdb) p frame.f_back.f_back
<frame at 0x7f87356b3640, file '/home/marco/miniconda3/envs/pandas-dev/lib/python3.8/pickle.py', line 1212, code load>
(Pdb) p frame.f_back.f_back
<frame at 0x7f87356b3640, file '/home/marco/miniconda3/envs/pandas-dev/lib/python3.8/pickle.py', line 1212, code load>
(Pdb) p frame.f_back.f_back.f_back
<frame at 0x7f8735765800, file '/home/marco/pandas-marco/pandas/compat/pickle_compat.py', line 277, code load>
(Pdb) p frame.f_back.f_back.f_back.f_back
<frame at 0x7f87356a6c40, file '/home/marco/pandas-marco/pandas/io/pickle.py', line 213, code read_pickle>
(Pdb) p frame.f_back.f_back.f_back.f_back.f_back
<frame at 0x7f873569f400, file '/home/marco/pandas-marco/pandas/tests/io/test_pickle.py', line 240, code test_legacy_sparse_warning>, I'll have a look at what can be done about that Any places where the stacklevel isn't correct should now be caught by the tests anyway, as with this PR it'd be checked for all warnings and |
|
Thanks for confirming. In any case, a check can be made in a follow up |
mroeschke
approved these changes
Aug 17, 2022
3 tasks
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* use find_stack_level everywhere * fixup * pyx fixups * fixup test_optional_dependency * fixup api * set check_stacklevel=False for some tests * use lru_cache for currentframe * fixup import in __init__ * add missing imports to pyx files * add missing import * fixup import in conversion * revert some __init__ changes * start n=1 * temporarily dont check stacklevel in _check_plot_works * catch some more warnings * dont check stacklevel in check_plot_works * fixup * ignore stacklevel in check_plot_works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.