Skip to content

WARN,TST check stacklevel for all warnings #47919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MarcoGorelli opened this issue Aug 1, 2022 · 0 comments · Fixed by #47998
Closed

WARN,TST check stacklevel for all warnings #47919

MarcoGorelli opened this issue Aug 1, 2022 · 0 comments · Fixed by #47998
Labels
Testing pandas testing functions or related to the test suite Warnings Warnings that appear or should be added to pandas

Comments

@MarcoGorelli
Copy link
Member

Currently, the stacklevel is only checked for two classes of warnings:

pandas/pandas/_testing/_warnings.py

Lines 132 to 134 in 14de3fd

if check_stacklevel and issubclass(
actual_warning.category, (FutureWarning, DeprecationWarning)
):

it would be good to extend this to other (all?) classes of warnings, and fixing the parts of the codebase where this fails
@MarcoGorelli MarcoGorelli added the Warnings Warnings that appear or should be added to pandas label Aug 1, 2022
@MarcoGorelli MarcoGorelli mentioned this issue Aug 1, 2022
Closed
5 tasks
@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Aug 1, 2022
@shourya5 shourya5 mentioned this issue Aug 3, 2022
Closed
2 tasks
@MarcoGorelli MarcoGorelli mentioned this issue Aug 7, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite Warnings Warnings that appear or should be added to pandas
Projects
None yet
Milestone
No milestone
2 participants
@mroeschke @MarcoGorelli