-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: Support For Interval __contains__ Other Interval (#46613) #47927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
212622b
ENH: Support For Interval __contains__ Other Interval (#46613)
kapiliyer 87ee5ba
ENH: Support For Interval __contains__ Other Interval (#46613)
kapiliyer 6dc7da3
Update doc/source/whatsnew/v1.5.0.rst
kapiliyer 29336eb
ENH: Support For Interval __contains__ Other Interval (#46613)
kapiliyer d94cf2b
ENH: Support For Interval __contains__ Other Interval (#46613)
kapiliyer 2297d40
Fix: Unintentionally Modified Range
kapiliyer d640efd
ENH: Support For Interval __contains__ Other Interval (#46613)
kapiliyer a9ad87e
Fix: Unintentionally Modified Range
kapiliyer 48d9aa4
ENH: Support For Interval __contains__ Other Interval (#46613)
kapiliyer 7784304
Merge branch 'main' into enh_46613
kapiliyer a009aa9
Merge branch 'main' into enh_46613
kapiliyer 2cce4db
Merge branch 'main' into enh_46613
kapiliyer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,10 +36,6 @@ def test_contains(self, interval): | |
assert 1 in interval | ||
assert 0 not in interval | ||
|
||
msg = "__contains__ not defined for two intervals" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changed by this enhancement. |
||
with pytest.raises(TypeError, match=msg): | ||
interval in interval | ||
|
||
interval_both = Interval(0, 1, "both") | ||
assert 0 in interval_both | ||
assert 1 in interval_both | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @venaturum if you'd like to review if this aligns with piso