ENH: Support For Interval __contains__ Other Interval (#46613) #47927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapiliyer
commented
Aug 2, 2022
| @@ -36,10 +36,6 @@ def test_contains(self, interval): | |||
| assert 1 in interval | |||
| assert 0 not in interval | |||
|
|
|||
| msg = "__contains__ not defined for two intervals" | |||
There was a problem hiding this comment.
Changed by this enhancement.
choucavalier
reviewed
Aug 3, 2022
choucavalier
approved these changes
Aug 3, 2022
|
Apologies for the mess in the history! I suggested @kapiliyer rebase rather than merge and I'm seeing now that the history's in a weird state. Later today I'll work with him to get his branch into a cleaner state. |
Co-authored-by: Valentin Iovene <[email protected]>
|
History should be in a saner state now. Apologies again for the trouble! |
mroeschke
reviewed
Aug 8, 2022
mroeschke
reviewed
Aug 8, 2022
| @@ -410,7 +412,17 @@ cdef class Interval(IntervalMixin): | |||
|
|
|||
| def __contains__(self, key) -> bool: | |||
| if _interval_like(key): | |||
| raise TypeError("__contains__ not defined for two intervals") | |||
| key_closed_left = key.inclusive in ('left', 'both') | |||
There was a problem hiding this comment.
cc @venaturum if you'd like to review if this aligns with piso
mroeschke
approved these changes
Aug 15, 2022
|
Thanks @kapiliyer! |
YYYasin19
pushed a commit
to YYYasin19/pandas
that referenced
this pull request
Aug 23, 2022
…) (pandas-dev#47927) * ENH: Support For Interval __contains__ Other Interval (pandas-dev#46613) * ENH: Support For Interval __contains__ Other Interval (pandas-dev#46613) * Update doc/source/whatsnew/v1.5.0.rst Co-authored-by: Valentin Iovene <[email protected]> * ENH: Support For Interval __contains__ Other Interval (pandas-dev#46613) * ENH: Support For Interval __contains__ Other Interval (pandas-dev#46613) * Fix: Unintentionally Modified Range * ENH: Support For Interval __contains__ Other Interval (pandas-dev#46613) * Fix: Unintentionally Modified Range * ENH: Support For Interval __contains__ Other Interval (pandas-dev#46613) Co-authored-by: Valentin Iovene <[email protected]>
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…) (pandas-dev#47927) * ENH: Support For Interval __contains__ Other Interval (pandas-dev#46613) * ENH: Support For Interval __contains__ Other Interval (pandas-dev#46613) * Update doc/source/whatsnew/v1.5.0.rst Co-authored-by: Valentin Iovene <[email protected]> * ENH: Support For Interval __contains__ Other Interval (pandas-dev#46613) * ENH: Support For Interval __contains__ Other Interval (pandas-dev#46613) * Fix: Unintentionally Modified Range * ENH: Support For Interval __contains__ Other Interval (pandas-dev#46613) * Fix: Unintentionally Modified Range * ENH: Support For Interval __contains__ Other Interval (pandas-dev#46613) Co-authored-by: Valentin Iovene <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.