Skip to content

BUG: fixed OutOfBoundsDatetime exception when errors=coerce #45319 #47794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 15, 2022
Merged

BUG: fixed OutOfBoundsDatetime exception when errors=coerce #45319 #47794

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ece009e
BUG: fixed OutOfBoundsDatetime exception when errors=coerce #45319
KingOfTheShow69 Jul 19, 2022
6dc5d48
Merge remote-tracking branch 'upstream/main' into coerce-bug
KingOfTheShow69 Jul 20, 2022
75e8fee
BUG: Added test and release note #45319
KingOfTheShow69 Jul 25, 2022
f17f358
BUG: Restructured test parameters #45319
KingOfTheShow69 Jul 29, 2022
57aff11
BUG: Restructured test #45319
KingOfTheShow69 Aug 3, 2022
4ea55b1
BUG: Restructured parameters for test #45319
KingOfTheShow69 Aug 9, 2022
b98f2eb
BUG: Renamed test and added raise and ignore cases #45319
KingOfTheShow69 Aug 10, 2022
dbed6bc
Merge branch 'main' into coerce-bug
srotondo Aug 10, 2022
9c13e42
BUG: Changed exception case #45319
KingOfTheShow69 Aug 11, 2022
0c9b76e
Merge branch 'coerce-bug' of https://github.com/srotondo/pandas into …
KingOfTheShow69 Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pandas/core/tools/datetimes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,11 @@ def _maybe_cache(
unique_dates = unique(arg)
if len(unique_dates) < len(arg):
cache_dates = convert_listlike(unique_dates, format)
cache_array = Series(cache_dates, index=unique_dates)
# GH#45319
try:
cache_array = Series(cache_dates, index=unique_dates)
except OutOfBoundsDatetime:
pass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense just to return cache_array here since the cache_array cannot be used due to the out of bounds date?

# GH#39882 and GH#35888 in case of None and NaT we get duplicates
if not cache_array.index.is_unique:
cache_array = cache_array[~cache_array.index.duplicated()]
Expand Down