BUG: fixed OutOfBoundsDatetime exception when errors=coerce #45319 #47794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Jul 20, 2022
|
This function that this change is in doesn't care about the error variable, shown by the fact that there is no argument for the errors in the code. This function will always return NaT, and the raise and coerce cases are dealt with later in the program. |
mroeschke
added
Datetime
mroeschke
reviewed
Jul 26, 2022
mroeschke
reviewed
Jul 29, 2022
mroeschke
reviewed
Jul 29, 2022
mroeschke
reviewed
Aug 10, 2022
| "series_length", | ||
| [40, start_caching_at, (start_caching_at + 1), (start_caching_at + 5)], | ||
| ) | ||
| def test_to_datetime_cache_coerce_50_lines(series_length): |
There was a problem hiding this comment.
Suggested change
| def test_to_datetime_cache_coerce_50_lines(series_length): | |
| def test_to_datetime_cache_coerce_50_lines_outofbounds(series_length): |
Also could you test the ignore and raise options as well?
mroeschke
reviewed
Aug 10, 2022
pandas/core/tools/datetimes.py
Outdated
| try: | ||
| cache_array = Series(cache_dates, index=unique_dates) | ||
| except OutOfBoundsDatetime: | ||
| pass |
There was a problem hiding this comment.
Does it make sense just to return cache_array here since the cache_array cannot be used due to the out of bounds date?
mroeschke
approved these changes
Aug 15, 2022
|
Thanks @srotondo |
YYYasin19
pushed a commit
to YYYasin19/pandas
that referenced
this pull request
Aug 23, 2022
…v#45319 (pandas-dev#47794) * BUG: fixed OutOfBoundsDatetime exception when errors=coerce pandas-dev#45319 * BUG: Added test and release note pandas-dev#45319 * BUG: Restructured test parameters pandas-dev#45319 * BUG: Restructured test pandas-dev#45319 * BUG: Restructured parameters for test pandas-dev#45319 * BUG: Renamed test and added raise and ignore cases pandas-dev#45319 * BUG: Changed exception case pandas-dev#45319 Co-authored-by: Steven Rotondo <[email protected]>
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…v#45319 (pandas-dev#47794) * BUG: fixed OutOfBoundsDatetime exception when errors=coerce pandas-dev#45319 * BUG: Added test and release note pandas-dev#45319 * BUG: Restructured test parameters pandas-dev#45319 * BUG: Restructured test pandas-dev#45319 * BUG: Restructured parameters for test pandas-dev#45319 * BUG: Renamed test and added raise and ignore cases pandas-dev#45319 * BUG: Changed exception case pandas-dev#45319 Co-authored-by: Steven Rotondo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.