Skip to content

Specify that both by and level should not be specified in groupby - GH40378 #47690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 28 commits into from

Conversation

GivyBoy
Copy link
Contributor

@GivyBoy GivyBoy commented Jul 12, 2022

@GivyBoy GivyBoy changed the title Proj Specify that both by and level should not be specified in groupby Jul 13, 2022
@GivyBoy GivyBoy changed the title Specify that both by and level should not be specified in groupby Specify that both by and level should not be specified in groupby - GH40378 Jul 13, 2022
@GivyBoy GivyBoy requested a review from jreback July 13, 2022 15:48
@mroeschke
Copy link
Member

Please review the documentation check errors: https://github.com/pandas-dev/pandas/runs/7312164428?check_suite_focus=true

@mroeschke mroeschke mentioned this pull request Jul 13, 2022
5 tasks
@GivyBoy GivyBoy requested a review from mroeschke July 14, 2022 11:17

@verbatim
In [1]: gb.<TAB> # noqa: E225, E999
:okexcept:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this need to change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gb.<TAB> doesn't pass the tests when I try to build the documentation. I also added :okexcept: because of a build error.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change this in a subsequent PR if this was failing locally to keep this PR scoped to the linked issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these changes still exist in the latest commit

@GivyBoy GivyBoy requested a review from mroeschke July 14, 2022 22:19
@GivyBoy
Copy link
Contributor Author

GivyBoy commented Jul 18, 2022

It seems as if there is something wrong with my local machine. I will be closing this PR and opening a new one soon. Thanks for the help!

@GivyBoy GivyBoy closed this Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: TypeError when trying to group on column name and index level at the same time
3 participants